Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1906473006: [Mac/GN] List missing nscolor_additions.mm file in //ui/base. (Closed)

Created:
4 years, 8 months ago by Robert Sesek
Modified:
4 years, 8 months ago
Reviewers:
erikchen
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac/GN] List missing nscolor_additions.mm file in //ui/base. BUG=431177 Committed: https://crrev.com/0d37ffb7a5acad0c1e71d3d70272075044d7dfef Cr-Commit-Position: refs/heads/master@{#388841}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M ui/base/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Robert Sesek
4 years, 8 months ago (2016-04-21 17:32:24 UTC) #2
erikchen
lgtm
4 years, 8 months ago (2016-04-21 17:33:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1906473006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1906473006/1
4 years, 8 months ago (2016-04-21 17:35:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 19:16:37 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:37:17 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/0d37ffb7a5acad0c1e71d3d70272075044d7dfef
Cr-Commit-Position: refs/heads/master@{#388841}

Powered by Google App Engine
This is Rietveld 408576698