Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1154)

Unified Diff: third_party/WebKit/Source/core/animation/TimingInput.h

Issue 1906463002: Web Animations: Throw TypeErrors for invalid timing parameters (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix unit tests Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/TimingInput.h
diff --git a/third_party/WebKit/Source/core/animation/TimingInput.h b/third_party/WebKit/Source/core/animation/TimingInput.h
index 2611357da2fd923ed0ed6be39b670848109b70b3..e72bc6a81f5c7cdc9edf3b6af905874b51eee1d8 100644
--- a/third_party/WebKit/Source/core/animation/TimingInput.h
+++ b/third_party/WebKit/Source/core/animation/TimingInput.h
@@ -15,19 +15,20 @@ class Dictionary;
class Document;
class ExceptionState;
class KeyframeEffectOptions;
+class UnrestrictedDoubleOrString;
class CORE_EXPORT TimingInput {
STATIC_ONLY(TimingInput);
public:
static bool convert(const KeyframeEffectOptions& timingInput, Timing& timingOutput, Document*, ExceptionState&);
- static Timing convert(double duration);
+ static bool convert(double duration, Timing& timingOutput, ExceptionState&);
static void setStartDelay(Timing&, double startDelay);
static void setEndDelay(Timing&, double endDelay);
static void setFillMode(Timing&, const String& fillMode);
- static void setIterationStart(Timing&, double iterationStart);
- static void setIterationCount(Timing&, double iterationCount);
- static void setIterationDuration(Timing&, double iterationDuration);
+ static bool setIterationStart(Timing&, double iterationStart, ExceptionState&);
+ static bool setIterationCount(Timing&, double iterationCount, ExceptionState&);
+ static bool setIterationDuration(Timing&, const UnrestrictedDoubleOrString&, ExceptionState&);
static void setPlaybackRate(Timing&, double playbackRate);
static void setPlaybackDirection(Timing&, const String& direction);
static bool setTimingFunction(Timing&, const String& timingFunctionString, Document*, ExceptionState&);
« no previous file with comments | « third_party/WebKit/Source/core/animation/Timing.h ('k') | third_party/WebKit/Source/core/animation/TimingInput.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698