third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp - Issue 1906463002: Web Animations: Throw TypeErrors for invalid timing parameters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp

Issue 1906463002: Web Animations: Throw TypeErrors for invalid timing parameters (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/KeyframeEffect.cpp ('k') | third_party/WebKit/Source/core/animation/TimingInput.h » ('j') | third_party/WebKit/Source/core/animation/TimingInput.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp

diff --git a/third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp b/third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp

index e5ecb3400b1e9b0d84c7d27b9c5b03eb5a0b2c72..3efd13661055f411541daa834f54792bb1b4d6fd 100644

--- a/third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp

+++ b/third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp

@@ -220,11 +220,13 @@ TEST_F(AnimationKeyframeEffectV8Test, SpecifiedSetters)

EXPECT_EQ("backwards", specified->fill());

EXPECT_EQ(0, specified->iterationStart());

- specified->setIterationStart(2);

+ specified->setIterationStart(2, exceptionState);

+ ASSERT_FALSE(exceptionState.hadException());

EXPECT_EQ(2, specified->iterationStart());

EXPECT_EQ(1, specified->iterations());

- specified->setIterations(10);

+ specified->setIterations(10, exceptionState);

+ ASSERT_FALSE(exceptionState.hadException());

EXPECT_EQ(10, specified->iterations());

EXPECT_EQ(1, specified->playbackRate());

@@ -259,7 +261,8 @@ TEST_F(AnimationKeyframeEffectV8Test, SetSpecifiedDuration)

UnrestrictedDoubleOrString inDuration;

inDuration.setUnrestrictedDouble(2.5);

- specified->setDuration(inDuration);

+ specified->setDuration(inDuration, exceptionState);

+ ASSERT_FALSE(exceptionState.hadException());

UnrestrictedDoubleOrString duration2;

specified->duration(duration2);

EXPECT_TRUE(duration2.isUnrestrictedDouble());