Web Animations: Throw TypeErrors for invalid timing parameters

third_party/WebKit/Source/core/animation/TimingInputTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/animation/TimingInput.h"
 
 #include "bindings/core/v8/V8BindingForTesting.h"
 #include "bindings/core/v8/V8KeyframeEffectOptions.h"
 #include "core/animation/AnimationEffectTiming.h"
 #include "core/animation/AnimationTestHelper.h"
 #include "core/testing/DummyPageHolder.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include <v8.h>
 
 namespace blink {
 
 class AnimationTimingInputTest : public ::testing::Test {
 protected:
     AnimationTimingInputTest()
         : m_isolate(v8::Isolate::GetCurrent())
         , m_scope(m_isolate)
     {
     }
 
     Timing applyTimingInputNumber(String timingProperty, double timingPropertyValue, bool& timingConversionSuccess)
     {
         v8::Local<v8::Object> timingInput = v8::Object::New(m_isolate);
         setV8ObjectPropertyAsNumber(m_isolate, timingInput, timingProperty, timingPropertyValue);
         KeyframeEffectOptions timingInputDictionary;
+        TrackExceptionState exceptionState;
         V8KeyframeEffectOptions::toImpl(m_isolate, timingInput, timingInputDictionary, exceptionState);
         Timing result;
-        timingConversionSuccess = TimingInput::convert(timingInputDictionary, result, nullptr, exceptionState);
+        timingConversionSuccess = TimingInput::convert(timingInputDictionary, result, nullptr, exceptionState) && !exceptionState.hadException();
         return result;
     }
 
     Timing applyTimingInputString(String timingProperty, String timingPropertyValue, bool& timingConversionSuccess)
     {
         v8::Local<v8::Object> timingInput = v8::Object::New(m_isolate);
         setV8ObjectPropertyAsString(m_isolate, timingInput, timingProperty, timingPropertyValue);
         KeyframeEffectOptions timingInputDictionary;
+        TrackExceptionState exceptionState;
         V8KeyframeEffectOptions::toImpl(m_isolate, timingInput, timingInputDictionary, exceptionState);
         Timing result;
-        timingConversionSuccess = TimingInput::convert(timingInputDictionary, result, nullptr, exceptionState);
+        timingConversionSuccess = TimingInput::convert(timingInputDictionary, result, nullptr, exceptionState) && !exceptionState.hadException();
         return result;
     }
 
     v8::Isolate* m_isolate;
-    TrackExceptionState exceptionState;
 
 private:
     V8TestingScope m_scope;
 };
 
 TEST_F(AnimationTimingInputTest, TimingInputStartDelay)
 {
     bool ignoredSuccess;
     EXPECT_EQ(1.1, applyTimingInputNumber("delay", 1100, ignoredSuccess).startDelay);
     EXPECT_EQ(-1, applyTimingInputNumber("delay", -1000, ignoredSuccess).startDelay);
@@ skipping 22 matching lines @@
     EXPECT_EQ(Timing::FillModeNone, applyTimingInputString("fill", "none", ignoredSuccess).fillMode);
     EXPECT_EQ(Timing::FillModeBackwards, applyTimingInputString("fill", "backwards", ignoredSuccess).fillMode);
     EXPECT_EQ(Timing::FillModeBoth, applyTimingInputString("fill", "both", ignoredSuccess).fillMode);
     EXPECT_EQ(defaultFillMode, applyTimingInputString("fill", "everything!", ignoredSuccess).fillMode);
     EXPECT_EQ(defaultFillMode, applyTimingInputString("fill", "backwardsandforwards", ignoredSuccess).fillMode);
     EXPECT_EQ(defaultFillMode, applyTimingInputNumber("fill", 2, ignoredSuccess).fillMode);
 }
 
 TEST_F(AnimationTimingInputTest, TimingInputIterationStart)
 {
-    bool ignoredSuccess;
-    EXPECT_EQ(1.1, applyTimingInputNumber("iterationStart", 1.1, ignoredSuccess).iterationStart);
-    EXPECT_EQ(0, applyTimingInputNumber("iterationStart", -1, ignoredSuccess).iterationStart);
-    EXPECT_EQ(0, applyTimingInputString("iterationStart", "Infinity", ignoredSuccess).iterationStart);
-    EXPECT_EQ(0, applyTimingInputString("iterationStart", "-Infinity", ignoredSuccess).iterationStart);
-    EXPECT_EQ(0, applyTimingInputString("iterationStart", "NaN", ignoredSuccess).iterationStart);
-    EXPECT_EQ(0, applyTimingInputString("iterationStart", "rubbish", ignoredSuccess).iterationStart);
+    bool success;
+    EXPECT_EQ(1.1, applyTimingInputNumber("iterationStart", 1.1, success).iterationStart);
+    EXPECT_TRUE(success);
+
+    applyTimingInputNumber("iterationStart", -1, success);
+    EXPECT_FALSE(success);
+
+    applyTimingInputString("iterationStart", "Infinity", success);
+    EXPECT_FALSE(success);
+
+    applyTimingInputString("iterationStart", "-Infinity", success);
+    EXPECT_FALSE(success);
+
+    applyTimingInputString("iterationStart", "NaN", success);
+    EXPECT_FALSE(success);
+
+    applyTimingInputString("iterationStart", "rubbish", success);
+    EXPECT_FALSE(success);
 }
 
 TEST_F(AnimationTimingInputTest, TimingInputIterationCount)
 {
-    bool ignoredSuccess;
-    EXPECT_EQ(2.1, applyTimingInputNumber("iterations", 2.1, ignoredSuccess).iterationCount);
-    EXPECT_EQ(0, applyTimingInputNumber("iterations", -1, ignoredSuccess).iterationCount);
+    bool success;
+    EXPECT_EQ(2.1, applyTimingInputNumber("iterations", 2.1, success).iterationCount);
+    EXPECT_TRUE(success);
 
-    Timing timing = applyTimingInputString("iterations", "Infinity", ignoredSuccess);
+    Timing timing = applyTimingInputString("iterations", "Infinity", success);
+    EXPECT_TRUE(success);
     EXPECT_TRUE(std::isinf(timing.iterationCount));
     EXPECT_GT(timing.iterationCount, 0);
 
-    EXPECT_EQ(0, applyTimingInputString("iterations", "-Infinity", ignoredSuccess).iterationCount);
-    EXPECT_EQ(1, applyTimingInputString("iterations", "NaN", ignoredSuccess).iterationCount);
-    EXPECT_EQ(1, applyTimingInputString("iterations", "rubbish", ignoredSuccess).iterationCount);
+    applyTimingInputNumber("iterations", -1, success);
+    EXPECT_FALSE(success);
+
+    applyTimingInputString("iterations", "-Infinity", success);
+    EXPECT_FALSE(success);
+
+    applyTimingInputString("iterations", "NaN", success);
+    EXPECT_FALSE(success);
+
+    applyTimingInputString("iterations", "rubbish", success);
+    EXPECT_FALSE(success);
 }
 
 TEST_F(AnimationTimingInputTest, TimingInputIterationDuration)
 {
-    bool ignoredSuccess;
-    EXPECT_EQ(1.1, applyTimingInputNumber("duration", 1100, ignoredSuccess).iterationDuration);
-    EXPECT_TRUE(std::isnan(applyTimingInputNumber("duration", -1000, ignoredSuccess).iterationDuration));
-    EXPECT_TRUE(std::isnan(applyTimingInputString("duration", "1000", ignoredSuccess).iterationDuration));
+    bool success;
+    EXPECT_EQ(1.1, applyTimingInputNumber("duration", 1100, success).iterationDuration);
+    EXPECT_TRUE(success);
 
-    Timing timing = applyTimingInputNumber("duration", std::numeric_limits<double>::infinity(), ignoredSuccess);
+    Timing timing = applyTimingInputNumber("duration", std::numeric_limits<double>::infinity(), success);
+    EXPECT_TRUE(success);
     EXPECT_TRUE(std::isinf(timing.iterationDuration));
     EXPECT_GT(timing.iterationDuration, 0);
 
-    EXPECT_TRUE(std::isnan(applyTimingInputString("duration", "-Infinity", ignoredSuccess).iterationDuration));
-    EXPECT_TRUE(std::isnan(applyTimingInputString("duration", "NaN", ignoredSuccess).iterationDuration));
-    EXPECT_TRUE(std::isnan(applyTimingInputString("duration", "auto", ignoredSuccess).iterationDuration));
-    EXPECT_TRUE(std::isnan(applyTimingInputString("duration", "rubbish", ignoredSuccess).iterationDuration));
+    EXPECT_TRUE(std::isnan(applyTimingInputString("duration", "auto", success).iterationDuration));
+    EXPECT_TRUE(success);
+
+    applyTimingInputString("duration", "1000", success);
+    EXPECT_FALSE(success);
+
+    applyTimingInputNumber("duration", -1000, success);
+    EXPECT_FALSE(success);
+
+    applyTimingInputString("duration", "-Infinity", success);
+    EXPECT_FALSE(success);
+
+    applyTimingInputString("duration", "NaN", success);
+    EXPECT_FALSE(success);
+
+    applyTimingInputString("duration", "rubbish", success);
+    EXPECT_FALSE(success);
 }
 
 TEST_F(AnimationTimingInputTest, TimingInputPlaybackRate)
 {
     bool ignoredSuccess;
     EXPECT_EQ(2.1, applyTimingInputNumber("playbackRate", 2.1, ignoredSuccess).playbackRate);
     EXPECT_EQ(-1, applyTimingInputNumber("playbackRate", -1, ignoredSuccess).playbackRate);
     EXPECT_EQ(1, applyTimingInputString("playbackRate", "Infinity", ignoredSuccess).playbackRate);
     EXPECT_EQ(1, applyTimingInputString("playbackRate", "-Infinity", ignoredSuccess).playbackRate);
     EXPECT_EQ(1, applyTimingInputString("playbackRate", "NaN", ignoredSuccess).playbackRate);
@@ skipping 52 matching lines @@
     applyTimingInputString("easing", "rubbish", success);
     EXPECT_FALSE(success);
     applyTimingInputNumber("easing", 2, success);
     EXPECT_FALSE(success);
     applyTimingInputString("easing", "initial", success);
     EXPECT_FALSE(success);
 }
 
 TEST_F(AnimationTimingInputTest, TimingInputEmpty)
 {
+    TrackExceptionState exceptionState;
     Timing controlTiming;
     Timing updatedTiming;
     bool success = TimingInput::convert(KeyframeEffectOptions(), updatedTiming, nullptr, exceptionState);
     EXPECT_TRUE(success);
+    EXPECT_FALSE(exceptionState.hadException());
 
     EXPECT_EQ(controlTiming.startDelay, updatedTiming.startDelay);
     EXPECT_EQ(controlTiming.fillMode, updatedTiming.fillMode);
     EXPECT_EQ(controlTiming.iterationStart, updatedTiming.iterationStart);
     EXPECT_EQ(controlTiming.iterationCount, updatedTiming.iterationCount);
     EXPECT_TRUE(std::isnan(updatedTiming.iterationDuration));
     EXPECT_EQ(controlTiming.playbackRate, updatedTiming.playbackRate);
     EXPECT_EQ(controlTiming.direction, updatedTiming.direction);
     EXPECT_EQ(*controlTiming.timingFunction, *updatedTiming.timingFunction);
 }
 
 } // namespace blink