Web Animations: Throw TypeErrors for invalid timing parameters

third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/animation/KeyframeEffect.h"
 
 #include "bindings/core/v8/Dictionary.h"
 #include "bindings/core/v8/UnionTypesCore.h"
 #include "bindings/core/v8/V8BindingForTesting.h"
 #include "bindings/core/v8/V8KeyframeEffectOptions.h"
@@ skipping 109 matching lines @@
     EXPECT_EQ(duration / 1000, animation->specifiedTiming().iterationDuration);
 }
 
 TEST_F(AnimationKeyframeEffectV8Test, CanOmitSpecifiedDuration)
 {
     Vector<Dictionary, 0> jsKeyframes;
     KeyframeEffect* animation = createAnimation(element.get(), jsKeyframes, exceptionState);
     EXPECT_TRUE(std::isnan(animation->specifiedTiming().iterationDuration));
 }
 
-TEST_F(AnimationKeyframeEffectV8Test, NegativeDurationIsAuto)
-{
-    Vector<Dictionary, 0> jsKeyframes;
-    KeyframeEffect* animation = createAnimation(element.get(), jsKeyframes, -2, exceptionState);
-    EXPECT_TRUE(std::isnan(animation->specifiedTiming().iterationDuration));
-}
-
 TEST_F(AnimationKeyframeEffectV8Test, SpecifiedGetters)
 {
     Vector<Dictionary, 0> jsKeyframes;
 
     v8::Local<v8::Object> timingInput = v8::Object::New(m_isolate);
     setV8ObjectPropertyAsNumber(m_isolate, timingInput, "delay", 2);
     setV8ObjectPropertyAsNumber(m_isolate, timingInput, "endDelay", 0.5);
     setV8ObjectPropertyAsString(m_isolate, timingInput, "fill", "backwards");
     setV8ObjectPropertyAsNumber(m_isolate, timingInput, "iterationStart", 2);
     setV8ObjectPropertyAsNumber(m_isolate, timingInput, "iterations", 10);
@@ skipping 65 matching lines @@
 
     EXPECT_EQ(0, specified->endDelay());
     specified->setEndDelay(0.5);
     EXPECT_EQ(0.5, specified->endDelay());
 
     EXPECT_EQ("auto", specified->fill());
     specified->setFill("backwards");
     EXPECT_EQ("backwards", specified->fill());
 
     EXPECT_EQ(0, specified->iterationStart());
-    specified->setIterationStart(2);
+    specified->setIterationStart(2, exceptionState);
+    ASSERT_FALSE(exceptionState.hadException());
     EXPECT_EQ(2, specified->iterationStart());
 
     EXPECT_EQ(1, specified->iterations());
-    specified->setIterations(10);
+    specified->setIterations(10, exceptionState);
+    ASSERT_FALSE(exceptionState.hadException());
     EXPECT_EQ(10, specified->iterations());
 
     EXPECT_EQ(1, specified->playbackRate());
     specified->setPlaybackRate(2);
     EXPECT_EQ(2, specified->playbackRate());
 
     EXPECT_EQ("normal", specified->direction());
     specified->setDirection("reverse");
     EXPECT_EQ("reverse", specified->direction());
 
@@ skipping 14 matching lines @@
     AnimationEffectTiming* specified = animation->timing();
 
     UnrestrictedDoubleOrString duration;
     specified->duration(duration);
     EXPECT_FALSE(duration.isUnrestrictedDouble());
     EXPECT_TRUE(duration.isString());
     EXPECT_EQ("auto", duration.getAsString());
 
     UnrestrictedDoubleOrString inDuration;
     inDuration.setUnrestrictedDouble(2.5);
-    specified->setDuration(inDuration);
+    specified->setDuration(inDuration, exceptionState);
+    ASSERT_FALSE(exceptionState.hadException());
     UnrestrictedDoubleOrString duration2;
     specified->duration(duration2);
     EXPECT_TRUE(duration2.isUnrestrictedDouble());
     EXPECT_EQ(2.5, duration2.getAsUnrestrictedDouble());
     EXPECT_FALSE(duration2.isString());
 }
 
 TEST_F(KeyframeEffectTest, TimeToEffectChange)
 {
     Timing timing;
@@ skipping 98 matching lines @@
     Timing timing;
     timing.iterationDuration = 5;
     KeyframeEffect* animation = KeyframeEffect::create(element.get(), nullptr, timing);
     EXPECT_EQ(element.get(), animation->target());
     document().timeline().play(animation);
     pageHolder.clear();
     element.clear();
 }
 
 } // namespace blink