Web Animations: Throw TypeErrors for invalid timing parameters

third_party/WebKit/Source/core/animation/ElementAnimation.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 36 matching lines @@
 
 class Dictionary;
 
 class ElementAnimation {
     STATIC_ONLY(ElementAnimation);
 public:
     static Animation* animate(ExecutionContext* executionContext, Element& element, const EffectModelOrDictionarySequenceOrDictionary& effectInput, double duration, ExceptionState& exceptionState)
     {
         EffectModel* effect = EffectInput::convert(&element, effectInput, executionContext, exceptionState);
         if (exceptionState.hadException())
-            return 0;
-        return animateInternal(element, effect, TimingInput::convert(duration));
+            return nullptr;
+
+        Timing timing;
+        if (!TimingInput::convert(duration, timing, exceptionState))
+            return nullptr;
+
+        return animateInternal(element, effect, timing);
     }
 
     static Animation* animate(ExecutionContext* executionContext, Element& element, const EffectModelOrDictionarySequenceOrDictionary& effectInput, const KeyframeEffectOptions& options, ExceptionState& exceptionState)
     {
         EffectModel* effect = EffectInput::convert(&element, effectInput, executionContext, exceptionState);
+        if (exceptionState.hadException())
+            return nullptr;
+
         Timing timing;
-        bool success = TimingInput::convert(options, timing, &element.document(), exceptionState);
-        if (!success || exceptionState.hadException())
-            return 0;
+        if (!TimingInput::convert(options, timing, &element.document(), exceptionState))
+            return nullptr;
 
         Animation* animation = animateInternal(element, effect, timing);
         animation->setId(options.id());
         return animation;
     }
 
     static Animation* animate(ExecutionContext* executionContext, Element& element, const EffectModelOrDictionarySequenceOrDictionary& effectInput, ExceptionState& exceptionState)
     {
         EffectModel* effect = EffectInput::convert(&element, effectInput, executionContext, exceptionState);
         if (exceptionState.hadException())
-            return 0;
+            return nullptr;
         return animateInternal(element, effect, Timing());
     }
 
     static HeapVector<Member<Animation>> getAnimations(Element& element)
     {
         HeapVector<Member<Animation>> animations;
 
         if (!element.hasAnimations())
             return animations;
 
         for (const auto& animation : element.document().timeline().getAnimations()) {
             ASSERT(animation->effect());
             if (toKeyframeEffect(animation->effect())->target() == element && (animation->effect()->isCurrent() || animation->effect()->isInEffect()))
                 animations.append(animation);
         }
         return animations;
     }
 
 private:
     static Animation* animateInternal(Element& element, EffectModel* effect, const Timing& timing)
     {
         KeyframeEffect* keyframeEffect = KeyframeEffect::create(&element, effect, timing);
         return element.document().timeline().play(keyframeEffect);
     }
 };
 
 } // namespace blink
 
 #endif // ElementAnimation_h