Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: third_party/WebKit/LayoutTests/web-animations-api/timed-item-specified-setters.html

Issue 1906463002: Web Animations: Throw TypeErrors for invalid timing parameters (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix unit tests Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/imported/web-platform-tests/web-animations/animation-effect-timing/iterations-expected.txt ('k') | third_party/WebKit/Source/core/animation/AnimationEffectTiming.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <script src="../resources/testharness.js"></script> 2 <script src="../resources/testharness.js"></script>
3 <script src="../resources/testharnessreport.js"></script> 3 <script src="../resources/testharnessreport.js"></script>
4
5 <body>
6 <div id='e'></div>
7 </body>
8
9 <script> 4 <script>
10 var element = document.getElementById('e'); 5 var typeError = {name: 'TypeError'};
11 var keyframes = [{opacity: '1', offset: 0}, {opacity: '0', offset: 1}]; 6 var timing = new KeyframeEffect(null, null).timing;
12
13 var specifiedTiming = new KeyframeEffect(element, keyframes).timing;
14 7
15 test(function() { 8 test(function() {
16 specifiedTiming.delay = 2; 9 timing.delay = 2;
17 assert_equals(specifiedTiming.delay, 2); 10 assert_equals(timing.delay, 2);
11 timing.delay = -4;
12 assert_equals(timing.delay, -4);
18 13
19 specifiedTiming.endDelay = 0.5; 14 assert_throws(typeError, () => timing.delay = NaN);
20 assert_equals(specifiedTiming.endDelay, 0.5); 15 assert_equals(timing.delay, -4);
21 16
22 specifiedTiming.fill = 'backwards'; 17 assert_throws(typeError, () => timing.delay = Infinity);
23 assert_equals(specifiedTiming.fill, 'backwards'); 18 assert_equals(timing.delay, -4);
19 }, 'AnimationEffectTiming should have a setter for delay.');
24 20
25 specifiedTiming.iterationStart = 2; 21 test(function() {
26 assert_equals(specifiedTiming.iterationStart, 2); 22 timing.endDelay = 0.5;
23 assert_equals(timing.endDelay, 0.5);
27 24
28 specifiedTiming.iterations = 10; 25 timing.endDelay = -5;
29 assert_equals(specifiedTiming.iterations, 10); 26 assert_equals(timing.endDelay, -5);
30 27
31 specifiedTiming.duration = 5; 28 assert_throws(typeError, () => timing.endDelay = NaN);
32 assert_equals(specifiedTiming.duration, 5); 29 assert_equals(timing.endDelay, -5);
33 specifiedTiming.duration = '6';
34 assert_equals(specifiedTiming.duration, 'auto');
35 specifiedTiming.duration = 'auto';
36 assert_equals(specifiedTiming.duration, 'auto');
37 specifiedTiming.duration = 'a';
38 assert_equals(specifiedTiming.duration, 'auto');
39 specifiedTiming.duration = '-1';
40 assert_equals(specifiedTiming.duration, 'auto');
41 30
42 specifiedTiming.playbackRate = 2; 31 assert_throws(typeError, () => timing.endDelay = Infinity);
43 assert_equals(specifiedTiming.playbackRate, 2); 32 assert_equals(timing.endDelay, -5);
33 }, 'AnimationEffectTiming should have a setter for endDelay.');
44 34
45 specifiedTiming.direction = 'reverse'; 35 test(function() {
46 assert_equals(specifiedTiming.direction, 'reverse'); 36 timing.fill = 'backwards';
37 assert_equals(timing.fill, 'backwards');
47 38
48 specifiedTiming.easing = "step-start"; 39 timing.fill = 'both';
49 assert_equals(specifiedTiming.easing, 'step-start'); 40 assert_equals(timing.fill, 'both');
50 }, 'TimedItem.timing should have a setter for each member of the underlying Timi ng object.'); 41 }, 'AnimationEffectTiming should have a setter for fill.');
42
43 test(function() {
44 timing.iterationStart = 1.5;
45 assert_equals(timing.iterationStart, 1.5);
46
47 assert_throws(typeError, () => timing.iterationStart = -0.5);
48 assert_equals(timing.iterationStart, 1.5);
49
50 assert_throws(typeError, () => timing.iterationStart = NaN);
51 assert_equals(timing.iterationStart, 1.5);
52
53 assert_throws(typeError, () => timing.iterationStart = Infinity);
54 assert_equals(timing.iterationStart, 1.5);
55 }, 'AnimationEffectTiming should have a setter for iterationStart.');
56
57 test(function() {
58 timing.iterations = 10;
59 assert_equals(timing.iterations, 10);
60
61 timing.iterations = Infinity;
62 assert_equals(timing.iterations, Infinity);
63
64 assert_throws(typeError, () => timing.iterations = -20);
65 assert_equals(timing.iterations, Infinity);
66
67 assert_throws(typeError, () => timing.iterations = NaN);
68 assert_equals(timing.iterations, Infinity);
69 }, 'AnimationEffectTiming should have a setter for iterations.');
70
71 test(function() {
72 timing.duration = Infinity;
73 assert_equals(timing.duration, Infinity);
74
75 timing.duration = 1234;
76 assert_equals(timing.duration, 1234);
77
78 assert_throws(typeError, () => timing.duration = -10);
79 assert_equals(timing.duration, 1234);
80
81 assert_throws(typeError, () => timing.duration = NaN);
82 assert_equals(timing.duration, 1234);
83
84 assert_throws(typeError, () => timing.duration = 'very long');
85 assert_equals(timing.duration, 1234);
86 }, 'AnimationEffectTiming should have a setter for duration.');
87
88 test(function() {
89 timing.playbackRate = 2;
90 assert_equals(timing.playbackRate, 2);
91
92 timing.playbackRate = -2;
93 assert_equals(timing.playbackRate, -2);
94
95 assert_throws(typeError, () => timing.playbackRate = NaN);
96 assert_equals(timing.playbackRate, -2);
97 }, 'AnimationEffectTiming should have a setter for playbackRate.');
98
99 test(function() {
100 timing.direction = 'reverse';
101 assert_equals(timing.direction, 'reverse');
102
103 timing.direction = 'alternate';
104 assert_equals(timing.direction, 'alternate');
105 }, 'AnimationEffectTiming should have a setter for direction.');
106
107 test(function() {
108 timing.easing = "step-start";
109 assert_equals(timing.easing, 'step-start');
110
111 timing.easing = "eAse\\2d iN-ouT";
112 assert_equals(timing.easing, 'ease-in-out');
113
114
115 assert_throws(typeError, () => timing.easing = 'ponies');
116 assert_equals(timing.easing, 'ease-in-out');
117 }, 'AnimationEffectTiming should have a setter for easing.');
51 </script> 118 </script>
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/imported/web-platform-tests/web-animations/animation-effect-timing/iterations-expected.txt ('k') | third_party/WebKit/Source/core/animation/AnimationEffectTiming.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698