Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 1906433002: Views: Add to desktop dialog is now modal. (Closed)

Created:
4 years, 8 months ago by Matt Giuca
Modified:
4 years, 8 months ago
Reviewers:
msw, Evan Stade
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Views: Add to desktop dialog is now modal. Previously, it allowed interaction with the page underneath, and DCHECK-failed upon opening. BUG=605008 Committed: https://crrev.com/e628940221550b9b7c81440c5fd65f852fbb174b Cr-Commit-Position: refs/heads/master@{#388636}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/ui/views/extensions/bookmark_app_confirmation_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/extensions/bookmark_app_confirmation_view.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Matt Giuca
4 years, 8 months ago (2016-04-20 06:57:44 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1906433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1906433002/1
4 years, 8 months ago (2016-04-20 06:57:55 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-20 07:44:15 UTC) #6
msw
this matches bookmark_editor_view.cc, lgtm!
4 years, 8 months ago (2016-04-20 15:57:32 UTC) #7
Evan Stade
thanks
4 years, 8 months ago (2016-04-20 21:28:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1906433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1906433002/1
4 years, 8 months ago (2016-04-21 00:01:07 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 00:30:11 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:29:01 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e628940221550b9b7c81440c5fd65f852fbb174b
Cr-Commit-Position: refs/heads/master@{#388636}

Powered by Google App Engine
This is Rietveld 408576698