Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1906423003: headless: Remove old load observer API (Closed)

Created:
4 years, 8 months ago by Sami
Modified:
4 years, 8 months ago
Reviewers:
altimin
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

headless: Remove old load observer API The equivalent DevTools events should now be used for observing page load progress. BUG=595353 Committed: https://crrev.com/585fa604895aa3b2301d5634389b69628a35ea74 Cr-Commit-Position: refs/heads/master@{#389488}

Patch Set 1 #

Patch Set 2 : Update headless shell. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -80 lines) Patch
M headless/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
M headless/app/headless_shell.cc View 1 4 chunks +34 lines, -13 lines 0 comments Download
M headless/lib/browser/headless_devtools_client_impl.cc View 1 1 chunk +6 lines, -5 lines 0 comments Download
M headless/lib/browser/headless_web_contents_impl.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M headless/lib/headless_browser_browsertest.cc View 1 2 chunks +4 lines, -1 line 0 comments Download
M headless/lib/headless_web_contents_browsertest.cc View 2 chunks +2 lines, -35 lines 0 comments Download
M headless/public/headless_web_contents.h View 1 chunk +0 lines, -3 lines 0 comments Download
M headless/test/headless_browser_test.cc View 1 3 chunks +31 lines, -11 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
Sami
4 years, 8 months ago (2016-04-25 12:40:43 UTC) #3
altimin
lgtm
4 years, 8 months ago (2016-04-25 14:24:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1906423003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1906423003/20001
4 years, 8 months ago (2016-04-25 14:43:22 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-generic_chromium_compile_only_ng/builds/127086)
4 years, 8 months ago (2016-04-25 14:50:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1906423003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1906423003/20001
4 years, 8 months ago (2016-04-25 14:52:24 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-generic_chromium_compile_only_ng/builds/127092)
4 years, 8 months ago (2016-04-25 14:58:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1906423003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1906423003/20001
4 years, 8 months ago (2016-04-25 15:54:00 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-25 16:08:06 UTC) #16
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 16:09:26 UTC) #18
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/585fa604895aa3b2301d5634389b69628a35ea74
Cr-Commit-Position: refs/heads/master@{#389488}

Powered by Google App Engine
This is Rietveld 408576698