Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1906413004: Fix missing downwards inference on fields, report more inference (Closed)

Created:
4 years, 8 months ago by Leaf
Modified:
4 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix missing downwards inference on fields, report more inference Use the element type on the variable declaration to set the downwards inference context, so that we get downwards inference from inferred types. Also eliminated some TODOs about places where we were not recording inferences. Fixes https://github.com/dart-lang/sdk/issues/25546 . BUG= R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/fa39d72861c911da4113251c4fbb0a22d8675b41

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -50 lines) Patch
M pkg/analyzer/lib/src/generated/resolver.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/static_type_analyzer.dart View 5 chunks +64 lines, -18 lines 0 comments Download
M pkg/analyzer/test/generated/strong_mode_test.dart View 1 chunk +35 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/checker_test.dart View 2 chunks +11 lines, -9 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart View 10 chunks +24 lines, -22 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Leaf
4 years, 8 months ago (2016-04-22 20:33:18 UTC) #4
Brian Wilkerson
lgtm
4 years, 8 months ago (2016-04-22 21:23:49 UTC) #5
Leaf
4 years, 8 months ago (2016-04-22 22:29:33 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fa39d72861c911da4113251c4fbb0a22d8675b41 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698