Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 19064002: Split ProcessHandle and its related routines into base/process/process_handle.h. (Closed)

Created:
7 years, 5 months ago by Robert Sesek
Modified:
7 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Split ProcessHandle and its related routines into base/process/process_handle.h. BUG=242290 R=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211663

Patch Set 1 #

Patch Set 2 : Ready for review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+397 lines, -545 lines) Patch
M base/base.gypi View 1 5 chunks +9 lines, -3 lines 0 comments Download
M base/process.h View 1 chunk +1 line, -22 lines 0 comments Download
M base/process/memory_linux.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
A base/process/process_handle.h View 1 chunk +96 lines, -0 lines 0 comments Download
A + base/process/process_handle_freebsd.cc View 1 chunk +1 line, -17 lines 0 comments Download
A + base/process/process_handle_linux.cc View 2 chunks +2 lines, -25 lines 0 comments Download
A base/process/process_handle_mac.cc View 1 chunk +27 lines, -0 lines 0 comments Download
A + base/process/process_handle_openbsd.cc View 1 chunk +0 lines, -18 lines 0 comments Download
A base/process/process_handle_posix.cc View 1 chunk +49 lines, -0 lines 0 comments Download
A base/process/process_handle_win.cc View 1 chunk +126 lines, -0 lines 0 comments Download
M base/process/process_metrics.h View 1 chunk +17 lines, -0 lines 0 comments Download
M base/process/process_metrics_ios.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M base/process/process_metrics_linux.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M base/process/process_metrics_posix.cc View 2 chunks +34 lines, -0 lines 0 comments Download
M base/process_util.h View 3 chunks +1 line, -69 lines 0 comments Download
D base/process_util_freebsd.cc View 1 chunk +0 lines, -55 lines 0 comments Download
M base/process_util_ios.mm View 1 chunk +0 lines, -25 lines 0 comments Download
D base/process_util_linux.cc View 1 chunk +0 lines, -53 lines 0 comments Download
M base/process_util_mac.mm View 1 chunk +0 lines, -13 lines 0 comments Download
D base/process_util_openbsd.cc View 1 chunk +0 lines, -67 lines 0 comments Download
M base/process_util_posix.cc View 2 chunks +6 lines, -67 lines 0 comments Download
M base/process_util_win.cc View 1 chunk +0 lines, -111 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Robert Sesek
Just one more split after this one :)
7 years, 5 months ago (2013-07-12 15:28:07 UTC) #1
brettw
lgtm
7 years, 5 months ago (2013-07-15 18:21:57 UTC) #2
Robert Sesek
7 years, 5 months ago (2013-07-15 18:29:47 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 manually as r211663 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698