color_picker.cc fix float-to-bool conversion warning

color_picker.cc fix float-to-bool conversion warning

New versions of Clang were warning (which we treat as an error)
on this code:

../../content/browser/devtools/protocol/color_picker.cc:184:7:
error: implicit conversion from 'const float' to 'bool' changes
value from 0 to false [-Werror,-Wfloat-bool-constant-conversion]
  if (kHotspotRadius) {
      ~~  ^~~~~~~~~~~~~~

BUG=605818
TBR=dgozman

Committed: https://crrev.com/24fec3b129239e5812f527033baeb1c7b27e8a48
Cr-Commit-Position: refs/heads/master@{#389016}

[hans, 2016-04-22 02:13:02]

hans@chromium.org changed reviewers:
+ dgozman@chromium.org, thakis@chromium.org

[hans, 2016-04-22 02:13:02]

Please take a look.

[Nico, 2016-04-22 02:15:58]

lgtm

[hans, 2016-04-22 02:18:31]

Description was changed from

==========
color_picker.cc fix float-to-bool conversion warning

New versions of Clang were warning (which we treat as an error)
on this code:

../../content/browser/devtools/protocol/color_picker.cc:184:7:
error: implicit conversion from 'const float' to 'bool' changes
value from 0 to false [-Werror,-Wfloat-bool-constant-conversion]
  if (kHotspotRadius) {
      ~~  ^~~~~~~~~~~~~~

BUG=605818
==========

to

==========
color_picker.cc fix float-to-bool conversion warning

New versions of Clang were warning (which we treat as an error)
on this code:

../../content/browser/devtools/protocol/color_picker.cc:184:7:
error: implicit conversion from 'const float' to 'bool' changes
value from 0 to false [-Werror,-Wfloat-bool-constant-conversion]
  if (kHotspotRadius) {
      ~~  ^~~~~~~~~~~~~~

BUG=605818
TBR=dgozman
==========

[hans, 2016-04-22 02:19:07]

dgozman: I'm TBR'ing this to fix the builds with tip-of-tree Clang. If you have
any comments, I'll be happy to address them afterwards.

[hans, 2016-04-22 02:19:11]

The CQ bit was checked by hans@chromium.org

[commit-bot: I haz the power, 2016-04-22 02:19:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1906333002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1906333002/1

[commit-bot: I haz the power, 2016-04-22 04:02:50]

Description was changed from

==========
color_picker.cc fix float-to-bool conversion warning

New versions of Clang were warning (which we treat as an error)
on this code:

../../content/browser/devtools/protocol/color_picker.cc:184:7:
error: implicit conversion from 'const float' to 'bool' changes
value from 0 to false [-Werror,-Wfloat-bool-constant-conversion]
  if (kHotspotRadius) {
      ~~  ^~~~~~~~~~~~~~

BUG=605818
TBR=dgozman
==========

to

==========
color_picker.cc fix float-to-bool conversion warning

New versions of Clang were warning (which we treat as an error)
on this code:

../../content/browser/devtools/protocol/color_picker.cc:184:7:
error: implicit conversion from 'const float' to 'bool' changes
value from 0 to false [-Werror,-Wfloat-bool-constant-conversion]
  if (kHotspotRadius) {
      ~~  ^~~~~~~~~~~~~~

BUG=605818
TBR=dgozman
==========

[commit-bot: I haz the power, 2016-04-22 04:02:50]

Committed patchset #1 (id:1)

[dgozman, 2016-04-22 07:20:12]

On 2016/04/22 02:19:07, hans wrote:
> dgozman: I'm TBR'ing this to fix the builds with tip-of-tree Clang. If you
have
> any comments, I'll be happy to address them afterwards.

No worries, this lgtm.

[commit-bot: I haz the power, 2016-04-22 19:43:54]

Description was changed from

==========
color_picker.cc fix float-to-bool conversion warning

New versions of Clang were warning (which we treat as an error)
on this code:

../../content/browser/devtools/protocol/color_picker.cc:184:7:
error: implicit conversion from 'const float' to 'bool' changes
value from 0 to false [-Werror,-Wfloat-bool-constant-conversion]
  if (kHotspotRadius) {
      ~~  ^~~~~~~~~~~~~~

BUG=605818
TBR=dgozman
==========

to

==========
color_picker.cc fix float-to-bool conversion warning

New versions of Clang were warning (which we treat as an error)
on this code:

../../content/browser/devtools/protocol/color_picker.cc:184:7:
error: implicit conversion from 'const float' to 'bool' changes
value from 0 to false [-Werror,-Wfloat-bool-constant-conversion]
  if (kHotspotRadius) {
      ~~  ^~~~~~~~~~~~~~

BUG=605818
TBR=dgozman

Committed: https://crrev.com/24fec3b129239e5812f527033baeb1c7b27e8a48
Cr-Commit-Position: refs/heads/master@{#389016}
==========

[commit-bot: I haz the power, 2016-04-22 19:43:55]

Patchset 1 (id:??) landed as
https://crrev.com/24fec3b129239e5812f527033baeb1c7b27e8a48
Cr-Commit-Position: refs/heads/master@{#389016}