Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 190633011: Size checking logic is duplicated. (Closed)

Created:
6 years, 9 months ago by zino
Modified:
6 years, 9 months ago
Reviewers:
Justin Novosad, eseidel
CC:
blink-reviews, aandrey+blink_chromium.org, dglazkov+blink, Rik, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Size checking logic is duplicated. ImageData::create() already checks size validation. BTW, createEmptyImageData() checks size validation again as same logic. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169313

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 1 chunk +5 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
zino
6 years, 9 months ago (2014-03-09 01:17:58 UTC) #1
zino
Could you please review this simple change?
6 years, 9 months ago (2014-03-14 08:35:17 UTC) #2
Justin Novosad
On 2014/03/14 08:35:17, zino wrote: > Could you please review this simple change? Good find. ...
6 years, 9 months ago (2014-03-14 12:10:31 UTC) #3
zino
The CQ bit was checked by jinho.bang@samsung.com
6 years, 9 months ago (2014-03-16 06:58:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/190633011/1
6 years, 9 months ago (2014-03-16 06:58:46 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-16 07:15:56 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-16 07:15:56 UTC) #7
zino
The CQ bit was checked by jinho.bang@samsung.com
6 years, 9 months ago (2014-03-16 07:58:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/190633011/1
6 years, 9 months ago (2014-03-16 07:58:40 UTC) #9
zino
The CQ bit was unchecked by jinho.bang@samsung.com
6 years, 9 months ago (2014-03-16 12:20:04 UTC) #10
zino
The CQ bit was checked by jinho.bang@samsung.com
6 years, 9 months ago (2014-03-16 12:20:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/190633011/1
6 years, 9 months ago (2014-03-16 12:20:25 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-16 22:42:18 UTC) #13
Message was sent while issue was closed. 
Change committed as 169313

Powered by Google App Engine
This is Rietveld 408576698