Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 190633010: Use DEFINE_ELEMENT_TYPE_CASTS*() macros for Element subclasses (Closed)

Created:
6 years, 9 months ago by Inactive
Modified:
6 years, 9 months ago
Reviewers:
adamk, eseidel
CC:
blink-reviews, philipj_slow, webcomponents-bugzilla_chromium.org, gasubic, sof, eae+blinkwatch, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, nessy, adamk+blink_chromium.org, Inactive, vcarbune.chromium, rwlbuis
Visibility:
Public.

Description

Use DEFINE_ELEMENT_TYPE_CASTS*() macros for Element subclasses Use DEFINE_ELEMENT_TYPE_CASTS*() macros for Element subclasses instead of the DEFINE_NODE_TYPE_CASTS*() ones. This makes the new Traversal<> API work for these Element types as well. R=eseidel, adamk BUG=346733 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168797

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -24 lines) Patch
M Source/core/dom/PseudoElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/shadow/InsertionPoint.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFormControlElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFrameElementBase.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFrameOwnerElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLLegendElement.cpp View 1 chunk +1 line, -7 lines 0 comments Download
M Source/core/html/HTMLMediaElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLPlugInElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTableCellElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTableColElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTableSectionElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTextFormControlElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLUnknownElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/LabelableElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/MediaControls.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/SliderThumbElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/track/vtt/VTTElement.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Inactive
6 years, 9 months ago (2014-03-09 02:25:22 UTC) #1
eseidel
lgtm
6 years, 9 months ago (2014-03-09 03:06:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/190633010/1
6 years, 9 months ago (2014-03-09 03:07:02 UTC) #3
commit-bot: I haz the power
6 years, 9 months ago (2014-03-09 03:21:35 UTC) #4
Message was sent while issue was closed. 
Change committed as 168797

Powered by Google App Engine
This is Rietveld 408576698