Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 190633007: linux_aura: Implement the tree/table colors. (Closed)

Created:
6 years, 9 months ago by Elliot Glaysher
Modified:
6 years, 9 months ago
Reviewers:
msw
CC:
chromium-reviews
Visibility:
Public.

Description

linux_aura: Implement the tree/table colors. This asks the system for the correct themes colors and vends them to the views tree/table classes. BUG=350144 R=msw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256009

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -50 lines) Patch
M chrome/browser/ui/libgtk2ui/native_theme_gtk2.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/native_theme_gtk2.cc View 4 chunks +29 lines, -50 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Elliot Glaysher
6 years, 9 months ago (2014-03-07 22:40:24 UTC) #1
msw
lgtm, but wrong bug #?
6 years, 9 months ago (2014-03-07 23:42:31 UTC) #2
Elliot Glaysher
On 2014/03/07 23:42:31, msw wrote: > lgtm, but wrong bug #? There isn't a dedicated ...
6 years, 9 months ago (2014-03-07 23:46:03 UTC) #3
Elliot Glaysher
The CQ bit was checked by erg@chromium.org
6 years, 9 months ago (2014-03-07 23:46:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/190633007/1
6 years, 9 months ago (2014-03-07 23:49:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/190633007/1
6 years, 9 months ago (2014-03-08 11:11:23 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-08 13:52:50 UTC) #7
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=234325
6 years, 9 months ago (2014-03-08 13:52:51 UTC) #8
Elliot Glaysher
6 years, 9 months ago (2014-03-10 19:39:05 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 manually as r256009 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698