Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 1906323004: Fixing generate-weak-test-chains.sh to generate correct certificates (Closed)

Created:
4 years, 8 months ago by svaldez
Modified:
4 years, 8 months ago
Reviewers:
davidben, Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixing generate-weak-test-chains.sh to generate correct certificates We add extensions to the leaf certificates generated by generate-weak-test-chains.sh in order to make them valid certificates for testing on Android. BUG=605960 Committed: https://crrev.com/655e2234eb572003c5641f817b6c045faae9b24f Cr-Commit-Position: refs/heads/master@{#389309}

Patch Set 1 #

Patch Set 2 : Fix SPKI. #

Total comments: 2

Patch Set 3 : Add text output. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+929 lines, -746 lines) Patch
M chrome/common/net/x509_certificate_model_unittest.cc View 1 1 chunk +5 lines, -5 lines 0 comments Download
M net/data/ssl/certificates/1024-rsa-ee-by-1024-rsa-intermediate.pem View 1 chunk +43 lines, -31 lines 0 comments Download
M net/data/ssl/certificates/1024-rsa-ee-by-2048-rsa-intermediate.pem View 1 chunk +53 lines, -41 lines 0 comments Download
M net/data/ssl/certificates/1024-rsa-ee-by-768-rsa-intermediate.pem View 1 chunk +40 lines, -29 lines 0 comments Download
M net/data/ssl/certificates/1024-rsa-ee-by-prime256v1-ecdsa-intermediate.pem View 1 chunk +38 lines, -26 lines 0 comments Download
M net/data/ssl/certificates/1024-rsa-intermediate.pem View 1 chunk +39 lines, -39 lines 0 comments Download
M net/data/ssl/certificates/2048-rsa-ee-by-1024-rsa-intermediate.pem View 1 chunk +55 lines, -43 lines 0 comments Download
M net/data/ssl/certificates/2048-rsa-ee-by-2048-rsa-intermediate.pem View 1 chunk +64 lines, -53 lines 0 comments Download
M net/data/ssl/certificates/2048-rsa-ee-by-768-rsa-intermediate.pem View 1 chunk +52 lines, -41 lines 0 comments Download
M net/data/ssl/certificates/2048-rsa-ee-by-prime256v1-ecdsa-intermediate.pem View 1 chunk +49 lines, -38 lines 0 comments Download
M net/data/ssl/certificates/2048-rsa-intermediate.pem View 1 chunk +51 lines, -51 lines 0 comments Download
M net/data/ssl/certificates/2048-rsa-root.pem View 1 2 1 chunk +56 lines, -56 lines 0 comments Download
M net/data/ssl/certificates/768-rsa-ee-by-1024-rsa-intermediate.pem View 1 chunk +40 lines, -29 lines 0 comments Download
M net/data/ssl/certificates/768-rsa-ee-by-2048-rsa-intermediate.pem View 1 chunk +50 lines, -38 lines 0 comments Download
M net/data/ssl/certificates/768-rsa-ee-by-768-rsa-intermediate.pem View 1 chunk +37 lines, -26 lines 0 comments Download
M net/data/ssl/certificates/768-rsa-ee-by-prime256v1-ecdsa-intermediate.pem View 1 chunk +35 lines, -24 lines 0 comments Download
M net/data/ssl/certificates/768-rsa-intermediate.pem View 1 chunk +36 lines, -36 lines 0 comments Download
M net/data/ssl/certificates/prime256v1-ecdsa-ee-by-1024-rsa-intermediate.pem View 1 chunk +37 lines, -26 lines 0 comments Download
M net/data/ssl/certificates/prime256v1-ecdsa-ee-by-2048-rsa-intermediate.pem View 1 chunk +47 lines, -36 lines 0 comments Download
M net/data/ssl/certificates/prime256v1-ecdsa-ee-by-768-rsa-intermediate.pem View 1 chunk +35 lines, -23 lines 0 comments Download
M net/data/ssl/certificates/prime256v1-ecdsa-ee-by-prime256v1-ecdsa-intermediate.pem View 1 chunk +32 lines, -21 lines 0 comments Download
M net/data/ssl/certificates/prime256v1-ecdsa-intermediate.pem View 1 chunk +34 lines, -34 lines 0 comments Download
M net/data/ssl/scripts/generate-weak-test-chains.sh View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
svaldez
4 years, 8 months ago (2016-04-22 20:30:51 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1906323004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1906323004/1
4 years, 8 months ago (2016-04-22 20:31:52 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/159398)
4 years, 8 months ago (2016-04-22 21:24:31 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1906323004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1906323004/20001
4 years, 8 months ago (2016-04-22 21:34:23 UTC) #8
Ryan Sleevi
LGTM % nit on the roots. https://codereview.chromium.org/1906323004/diff/20001/net/data/ssl/certificates/2048-rsa-root.pem File net/data/ssl/certificates/2048-rsa-root.pem (right): https://codereview.chromium.org/1906323004/diff/20001/net/data/ssl/certificates/2048-rsa-root.pem#newcode1 net/data/ssl/certificates/2048-rsa-root.pem:1: -----BEGIN CERTIFICATE----- Update ...
4 years, 8 months ago (2016-04-22 21:49:33 UTC) #9
svaldez
https://codereview.chromium.org/1906323004/diff/20001/net/data/ssl/certificates/2048-rsa-root.pem File net/data/ssl/certificates/2048-rsa-root.pem (right): https://codereview.chromium.org/1906323004/diff/20001/net/data/ssl/certificates/2048-rsa-root.pem#newcode1 net/data/ssl/certificates/2048-rsa-root.pem:1: -----BEGIN CERTIFICATE----- On 2016/04/22 21:49:33, Ryan Sleevi wrote: > ...
4 years, 8 months ago (2016-04-22 21:55:48 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1906323004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1906323004/40001
4 years, 8 months ago (2016-04-22 21:56:10 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-22 23:52:39 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 23:54:44 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/655e2234eb572003c5641f817b6c045faae9b24f
Cr-Commit-Position: refs/heads/master@{#389309}

Powered by Google App Engine
This is Rietveld 408576698