recipe_modules/path/example.expected/win.json - Issue 1906323003: recipe engine: extract infra-specific paths out of the engine

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: recipe_modules/path/example.expected/win.json

Issue 1906323003: recipe engine: extract infra-specific paths out of the engine (Closed) Base URL: https://github.com/luci/recipes-py.git@master

Patch Set: presubmit Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« recipe_modules/generator_script/example.py ('K') | « recipe_modules/path/example.expected/mac_swarming.json ('k') | recipe_modules/path/example.expected/win_kitchen.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: recipe_modules/path/example.expected/win.json

diff --git a/recipe_modules/path/example.expected/win.json b/recipe_modules/path/example.expected/win.json

index a53a727ba853a90c9d869cab156bdc3b12b5c8fa..b5920495ce3b0176481cb020421b9f0050f650f5 100644

--- a/recipe_modules/path/example.expected/win.json

+++ b/recipe_modules/path/example.expected/win.json

@@ -2,9 +2,8 @@

{

"cmd": [

"/bin/echo",

- "[SLAVE_BUILD]\\foo"

+ "[TMP_BASE]\\foo"

- "cwd": "[SLAVE_BUILD]",

"name": "step1"

{

@@ -12,7 +11,6 @@

"echo",

"RECIPE_MODULE[recipe_engine::path]\\resources\\dir\\file.py"

- "cwd": "[SLAVE_BUILD]",

"name": "print resource"

{

@@ -20,23 +18,20 @@

"echo",

"RECIPE_PACKAGE_REPO[recipe_engine]\\dir\\file.py"

- "cwd": "[SLAVE_BUILD]",

"name": "print package dir"

{

"cmd": [

"/bin/echo",

- "[SLAVE_BUILD]\\checkout\\jerky"

+ "[TMP_BASE]\\checkout\\jerky"

- "cwd": "[SLAVE_BUILD]",

"name": "checkout path"

{

"cmd": [

"touch",

- "[SLAVE_BUILD]\\new_file"

+ "[TMP_BASE]\\new_file"

- "cwd": "[SLAVE_BUILD]",

"name": "touch me"

{