Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 1906283002: Remove blink dependencies from mojo_public_bindings_unittests on ios. (Closed)

Created:
4 years, 8 months ago by Sam McNally
Modified:
4 years, 8 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chrome-apps-syd-reviews_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove blink dependencies from mojo_public_bindings_unittests on ios. BUG=605508 Committed: https://crrev.com/681920515d9619dd3b1bc3db6b36e2b086f8055f Cr-Commit-Position: refs/heads/master@{#389397}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -3 lines) Patch
M mojo/mojo_edk_tests.gyp View 1 chunk +17 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/tests/BUILD.gn View 1 3 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Sam McNally
4 years, 8 months ago (2016-04-22 01:17:38 UTC) #4
Nico
https://codereview.chromium.org/1906283002/diff/40001/mojo/public/cpp/bindings/tests/BUILD.gn File mojo/public/cpp/bindings/tests/BUILD.gn (right): https://codereview.chromium.org/1906283002/diff/40001/mojo/public/cpp/bindings/tests/BUILD.gn#newcode64 mojo/public/cpp/bindings/tests/BUILD.gn:64: sources -= [ in gn, we prefer to only ...
4 years, 8 months ago (2016-04-22 01:46:17 UTC) #6
Sam McNally
https://codereview.chromium.org/1906283002/diff/40001/mojo/public/cpp/bindings/tests/BUILD.gn File mojo/public/cpp/bindings/tests/BUILD.gn (right): https://codereview.chromium.org/1906283002/diff/40001/mojo/public/cpp/bindings/tests/BUILD.gn#newcode64 mojo/public/cpp/bindings/tests/BUILD.gn:64: sources -= [ On 2016/04/22 01:46:17, Nico wrote: > ...
4 years, 8 months ago (2016-04-22 01:57:43 UTC) #7
Nico
I think that's a book in the cookbook. I'll fix.
4 years, 8 months ago (2016-04-22 01:59:30 UTC) #8
Ken Rockot(use gerrit already)
lgtm
4 years, 8 months ago (2016-04-22 18:27:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1906283002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1906283002/60001
4 years, 8 months ago (2016-04-24 02:20:21 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 8 months ago (2016-04-24 03:07:50 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-24 03:09:09 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/681920515d9619dd3b1bc3db6b36e2b086f8055f
Cr-Commit-Position: refs/heads/master@{#389397}

Powered by Google App Engine
This is Rietveld 408576698