content/browser/dom_storage/dom_storage_namespace.cc - Issue 1906243002: [tracing] Add a memory dump provider for DOM storage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/dom_storage/dom_storage_namespace.cc

Issue 1906243002: [tracing] Add a memory dump provider for DOM storage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/dom_storage/dom_storage_context_impl.cc ('K') | « content/browser/dom_storage/dom_storage_namespace.h ('k') | content/browser/dom_storage/dom_storage_task_runner.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/dom_storage/dom_storage_namespace.cc

diff --git a/content/browser/dom_storage/dom_storage_namespace.cc b/content/browser/dom_storage/dom_storage_namespace.cc

index a8681b6e6c2b148491689f6c47b543172dbab08d..a5e35e1630f31e80181fd9a8832ae4ea47060d52 100644

--- a/content/browser/dom_storage/dom_storage_namespace.cc

+++ b/content/browser/dom_storage/dom_storage_namespace.cc

@@ -176,6 +176,14 @@ unsigned int DOMStorageNamespace::CountInMemoryAreas() const {

return area_count;

}

+bool DOMStorageNamespace::OnMemoryDump(

+ base::trace_event::ProcessMemoryDump* pmd) {

+ DCHECK(task_runner_->IsRunningOnPrimarySequence());

+ for (const auto& it : areas_)

+ it.second.area_->OnMemoryDump(pmd);

+ return true;

DOMStorageNamespace::AreaHolder*

DOMStorageNamespace::GetAreaHolder(const GURL& origin) {

AreaMap::iterator found = areas_.find(origin);