Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1906213004: Simplify PointerEventFactory::getPointerIdsOfType() return type. (Closed)

Created:
4 years, 8 months ago by sof
Modified:
4 years, 8 months ago
CC:
chromium-reviews, blink-reviews, dtapuska+blinkwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify PointerEventFactory::getPointerIdsOfType() return type. A Vector<int> is sufficient. R= BUG= Committed: https://crrev.com/e6f498cc57d9067379a0b8f770c049ae62817ecd Cr-Commit-Position: refs/heads/master@{#389372}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/core/events/PointerEventFactory.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/PointerEventFactory.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/input/PointerEventManager.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
sof
please take a look.
4 years, 8 months ago (2016-04-22 09:48:27 UTC) #2
dtapuska
On 2016/04/22 09:48:27, sof wrote: > please take a look. drive by; lgtm
4 years, 8 months ago (2016-04-22 13:45:12 UTC) #3
haraken
LGTM
4 years, 8 months ago (2016-04-22 18:12:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1906213004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1906213004/1
4 years, 8 months ago (2016-04-23 05:55:49 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-23 07:12:24 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-23 07:14:00 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e6f498cc57d9067379a0b8f770c049ae62817ecd
Cr-Commit-Position: refs/heads/master@{#389372}

Powered by Google App Engine
This is Rietveld 408576698