Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1417)

Unified Diff: chrome/browser/ui/android/usb_chooser_dialog_android.cc

Issue 1906183002: WebUSB Android chooser should be closed when "Get help" button is pressed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: WebUSB Android chooser should be closed when "Get help" button is pressed Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/android/usb_chooser_dialog_android.cc
diff --git a/chrome/browser/ui/android/usb_chooser_dialog_android.cc b/chrome/browser/ui/android/usb_chooser_dialog_android.cc
index f1454a314d44453b660396d9320d11a97b9adbab..c049c31933b445442f5b480787000e8151f8b5b4 100644
--- a/chrome/browser/ui/android/usb_chooser_dialog_android.cc
+++ b/chrome/browser/ui/android/usb_chooser_dialog_android.cc
@@ -166,6 +166,11 @@ void UsbChooserDialogAndroid::LoadUsbHelpPage(
JNIEnv* env,
const base::android::JavaParamRef<jobject>& obj) {
OpenUrl(chrome::kChooserUsbOverviewURL);
+ callback_.Run(nullptr);
Yaron 2016/04/21 21:45:37 Just call |Cancel|?
juncai 2016/04/21 21:55:07 Done.
+ callback_.reset(); // Reset |callback_| so that it is only run once.
+ Java_UsbChooserDialog_closeDialog(base::android::AttachCurrentThread(),
+ java_dialog_.obj());
+ RecordWebUsbChooserClosure(WEBUSB_CHOOSER_CLOSED_CANCELLED);
}
// Get a list of devices that can be shown in the chooser bubble UI for
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698