Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 1906153002: File API: Add a use counter for nonstandard 'endings' option (Closed)

Created:
4 years, 8 months ago by jsbell
Modified:
4 years, 8 months ago
CC:
chromium-reviews, blink-reviews, asvitkine+watch_chromium.org, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

File API: Add a use counter for nonstandard 'endings' option Chrome supports the nonstandard 'endings' option for the Blob and File constructors, which normalizes CR in the data to CR+LF on Windows. It'd be nice to eliminate this if we can, so let's measure the usage. BUG=605710 Committed: https://crrev.com/ec90317104f275c3e818f1a6e4d800ce5c8d6990 Cr-Commit-Position: refs/heads/master@{#389055}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M third_party/WebKit/Source/core/fileapi/Blob.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fileapi/Blob.cpp View 3 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/fileapi/Blob.idl View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/fileapi/File.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fileapi/File.cpp View 3 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/fileapi/File.idl View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
jsbell
philipj@ - can you review the Blink changes? mpearson@ - can you review the histograms ...
4 years, 8 months ago (2016-04-21 20:35:44 UTC) #2
Mark P
histograms.xml lgtm
4 years, 8 months ago (2016-04-21 20:50:31 UTC) #4
philipj_slow
lgtm
4 years, 8 months ago (2016-04-22 08:27:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1906153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1906153002/1
4 years, 8 months ago (2016-04-22 08:27:28 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-22 08:32:11 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:45:25 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ec90317104f275c3e818f1a6e4d800ce5c8d6990
Cr-Commit-Position: refs/heads/master@{#389055}

Powered by Google App Engine
This is Rietveld 408576698