Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1097)

Issue 1906133002: Remove unused CFX_IntArray. (Closed)

Created:
4 years, 8 months ago by Tom Sepez
Modified:
4 years, 8 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove unused CFX_IntArray. The only place its used, elements are added to it but the array is not used otherwise. Committed: https://pdfium.googlesource.com/pdfium/+/3fea70cb133ca71c800482853473797a352ece16

Patch Set 1 #

Patch Set 2 : Looks to be unused #

Total comments: 1

Patch Set 3 : static_cast #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -69 lines) Patch
M fpdfsdk/formfiller/cffl_listbox.cpp View 1 2 1 chunk +16 lines, -31 lines 0 comments Download
M fpdfsdk/fsdk_baseannot.cpp View 1 1 chunk +0 lines, -33 lines 0 comments Download
M fpdfsdk/include/fsdk_baseannot.h View 1 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Tom Sepez
Dan, for review.
4 years, 8 months ago (2016-04-21 20:25:42 UTC) #3
dsinclair
lgtm https://codereview.chromium.org/1906133002/diff/20001/fpdfsdk/formfiller/cffl_listbox.cpp File fpdfsdk/formfiller/cffl_listbox.cpp (right): https://codereview.chromium.org/1906133002/diff/20001/fpdfsdk/formfiller/cffl_listbox.cpp#newcode114 fpdfsdk/formfiller/cffl_listbox.cpp:114: CPWL_ListBox* pListBox = (CPWL_ListBox*)GetPDFWindow(pPageView, FALSE); nit: static_cast
4 years, 8 months ago (2016-04-21 20:28:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1906133002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1906133002/40001
4 years, 8 months ago (2016-04-21 20:36:45 UTC) #7
Tom Sepez
done
4 years, 8 months ago (2016-04-21 20:36:46 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-21 20:48:01 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/3fea70cb133ca71c800482853473797a352e...

Powered by Google App Engine
This is Rietveld 408576698