Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Unified Diff: base/task_scheduler/scheduler_worker_thread_unittest.cc

Issue 1906083002: TaskScheduler: Remove base/task_scheduler/utils.h/.cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@sched_2_stack
Patch Set: CR gab #16 Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/task_scheduler/scheduler_worker_thread_stack_unittest.cc ('k') | base/task_scheduler/utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/task_scheduler/scheduler_worker_thread_unittest.cc
diff --git a/base/task_scheduler/scheduler_worker_thread_unittest.cc b/base/task_scheduler/scheduler_worker_thread_unittest.cc
index 0131dcf0d7b07f9989ebf46d7247fd9b247fb29c..44ecf28a989988f2fc581a14f627aca5c8352c06 100644
--- a/base/task_scheduler/scheduler_worker_thread_unittest.cc
+++ b/base/task_scheduler/scheduler_worker_thread_unittest.cc
@@ -77,7 +77,7 @@ class TaskSchedulerWorkerThreadTest : public testing::TestWithParam<size_t>,
std::vector<scoped_refptr<Sequence>> EnqueuedSequences() {
AutoSchedulerLock auto_lock(lock_);
- return enqueued_sequences_;
+ return re_enqueued_sequences_;
}
std::unique_ptr<SchedulerWorkerThread> worker_thread_;
@@ -133,10 +133,11 @@ class TaskSchedulerWorkerThreadTest : public testing::TestWithParam<size_t>,
}
// This override verifies that |sequence| contains the expected number of
- // Tasks and adds it to |enqueued_sequences_|. Unlike a normal EnqueueSequence
+ // Tasks and adds it to |re_re_enqueued_sequences_|. Unlike a normal
gab 2016/04/25 19:28:07 s/re_re_/re_/ :-)
fdoray 2016/04/25 19:35:09 Done.
+ // ReEnqueueSequence
// implementation, it doesn't reinsert |sequence| into a queue for further
// execution.
- void EnqueueSequence(scoped_refptr<Sequence> sequence) override {
+ void ReEnqueueSequence(scoped_refptr<Sequence> sequence) override {
EXPECT_GT(TasksPerSequence(), 1U);
// Verify that |sequence| contains TasksPerSequence() - 1 Tasks.
@@ -146,10 +147,10 @@ class TaskSchedulerWorkerThreadTest : public testing::TestWithParam<size_t>,
}
EXPECT_FALSE(sequence->PeekTask());
- // Add |sequence| to |enqueued_sequences_|.
+ // Add |sequence| to |re_enqueued_sequences_|.
AutoSchedulerLock auto_lock(lock_);
- enqueued_sequences_.push_back(std::move(sequence));
- EXPECT_LE(enqueued_sequences_.size(), created_sequences_.size());
+ re_enqueued_sequences_.push_back(std::move(sequence));
+ EXPECT_LE(re_enqueued_sequences_.size(), created_sequences_.size());
}
void RunTaskCallback() {
@@ -183,7 +184,7 @@ class TaskSchedulerWorkerThreadTest : public testing::TestWithParam<size_t>,
std::vector<scoped_refptr<Sequence>> created_sequences_;
// Sequences passed to EnqueueSequence().
- std::vector<scoped_refptr<Sequence>> enqueued_sequences_;
+ std::vector<scoped_refptr<Sequence>> re_enqueued_sequences_;
// Number of times that RunTaskCallback() has been called.
size_t num_run_tasks_ = 0;
« no previous file with comments | « base/task_scheduler/scheduler_worker_thread_stack_unittest.cc ('k') | base/task_scheduler/utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698