Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1831)

Unified Diff: base/task_scheduler/scheduler_thread_pool_interface.h

Issue 1906083002: TaskScheduler: Remove base/task_scheduler/utils.h/.cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@sched_2_stack
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/task_scheduler/scheduler_thread_pool_interface.h
diff --git a/base/task_scheduler/scheduler_task_executor.h b/base/task_scheduler/scheduler_thread_pool_interface.h
similarity index 51%
rename from base/task_scheduler/scheduler_task_executor.h
rename to base/task_scheduler/scheduler_thread_pool_interface.h
index 7b4018d041e29e11ad6a0b1f639757c6c4e481ed..3339849e00a88bd5234088cb9bc63f931d998776 100644
--- a/base/task_scheduler/scheduler_task_executor.h
+++ b/base/task_scheduler/scheduler_thread_pool_interface.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef BASE_TASK_SCHEDULER_SCHEDULER_TASK_EXECUTOR_H_
-#define BASE_TASK_SCHEDULER_SCHEDULER_TASK_EXECUTOR_H_
+#ifndef BASE_TASK_SCHEDULER_SCHEDULER_THREAD_POOL_INTERFACE_H_
+#define BASE_TASK_SCHEDULER_SCHEDULER_THREAD_POOL_INTERFACE_H_
#include <memory>
@@ -15,19 +15,19 @@
namespace base {
namespace internal {
-// Interface for a component that runs Tasks.
-class BASE_EXPORT SchedulerTaskExecutor {
+// Interface for a thread pool.
gab 2016/04/22 18:53:56 s/Interface/Minimal post task interface/ ?
fdoray 2016/04/22 22:18:14 Done. s/Interface/Minimal interface/. It's not jus
+class BASE_EXPORT SchedulerThreadPoolInterface {
robliao 2016/04/22 20:22:25 It's not common to have a class with Interface as
fdoray 2016/04/22 22:18:14 Renamed SchedulerThreadPoolInterface -> SchedulerT
public:
- virtual ~SchedulerTaskExecutor() = default;
+ virtual ~SchedulerThreadPoolInterface() = default;
- // Posts |task| to be executed by this component as part of |sequence|. The
+ // Posts |task| to be executed by this thread pool as part of |sequence|. The
// scheduler's TaskTracker must have allowed |task| to be posted before this
// is called. This must only be called after |task|'s delayed run time.
- virtual void PostTaskWithSequence(std::unique_ptr<Task> task,
- scoped_refptr<Sequence> sequence) = 0;
+ virtual void PostTaskWithSequenceNow(std::unique_ptr<Task> task,
+ scoped_refptr<Sequence> sequence) = 0;
};
} // namespace internal
} // namespace base
-#endif // BASE_TASK_SCHEDULER_SCHEDULER_TASK_EXECUTOR_H_
+#endif // BASE_TASK_SCHEDULER_SCHEDULER_THREAD_POOL_INTERFACE_H_

Powered by Google App Engine
This is Rietveld 408576698