Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1078)

Unified Diff: base/task_scheduler/scheduler_thread_pool.h

Issue 1906083002: TaskScheduler: Remove base/task_scheduler/utils.h/.cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@sched_2_stack
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/task_scheduler/scheduler_thread_pool.h
diff --git a/base/task_scheduler/scheduler_thread_pool.h b/base/task_scheduler/scheduler_thread_pool.h
index df37841d3302cd9c813b46e28fb27fb16de11213..baf2386c0dcb4b2a74d96af2b53288531f5e8698 100644
--- a/base/task_scheduler/scheduler_thread_pool.h
+++ b/base/task_scheduler/scheduler_thread_pool.h
@@ -18,7 +18,7 @@
#include "base/task_runner.h"
#include "base/task_scheduler/priority_queue.h"
#include "base/task_scheduler/scheduler_lock.h"
-#include "base/task_scheduler/scheduler_task_executor.h"
+#include "base/task_scheduler/scheduler_thread_pool_interface.h"
#include "base/task_scheduler/scheduler_unique_stack.h"
#include "base/task_scheduler/scheduler_worker_thread.h"
#include "base/task_scheduler/sequence.h"
@@ -34,7 +34,7 @@ struct SequenceSortKey;
class TaskTracker;
// A pool of threads that run Tasks. This class is thread-safe.
-class BASE_EXPORT SchedulerThreadPool : public SchedulerTaskExecutor {
+class BASE_EXPORT SchedulerThreadPool : public SchedulerThreadPoolInterface {
public:
// Callback invoked when a Sequence isn't empty after a worker thread pops a
// Task from it.
@@ -78,9 +78,14 @@ class BASE_EXPORT SchedulerThreadPool : public SchedulerTaskExecutor {
// allowed to complete their execution. This can only be called once.
void JoinForTesting();
- // SchedulerTaskExecutor:
- void PostTaskWithSequence(std::unique_ptr<Task> task,
- scoped_refptr<Sequence> sequence) override;
+ // Posts |task| to be executed as part of |sequence|. Returns true if |task|
+ // is posted.
+ bool PostTaskWithSequence(std::unique_ptr<Task> task,
+ scoped_refptr<Sequence> sequence);
+
+ // SchedulerThreadPoolInterface:
+ void PostTaskWithSequenceNow(std::unique_ptr<Task> task,
+ scoped_refptr<Sequence> sequence) override;
private:
class SchedulerWorkerThreadDelegateImpl;

Powered by Google App Engine
This is Rietveld 408576698