Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1079)

Unified Diff: cc/layers/layer_impl.cc

Issue 1906003002: cc: Stop cache transform invertibility at Layer and LayerImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: more cleanup Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/layers/layer_impl.cc
diff --git a/cc/layers/layer_impl.cc b/cc/layers/layer_impl.cc
index cc41ff717f6c707d264d15d50d44792f8dcfd21a..e26942abf5279741f8bd19be0667272ccf23891f 100644
--- a/cc/layers/layer_impl.cc
+++ b/cc/layers/layer_impl.cc
@@ -70,7 +70,6 @@ LayerImpl::LayerImpl(LayerTreeImpl* tree_impl, int id)
should_check_backface_visibility_(false),
draws_content_(false),
hide_layer_and_subtree_(false),
- transform_is_invertible_(true),
is_container_for_fixed_position_layers_(false),
is_affected_by_page_scale_(true),
was_ever_ready_since_last_transform_animation_(true),
@@ -523,7 +522,7 @@ void LayerImpl::PushPropertiesTo(LayerImpl* layer) {
layer->SetUseLocalTransformForBackfaceVisibility(
use_local_transform_for_backface_visibility_);
layer->SetShouldCheckBackfaceVisibility(should_check_backface_visibility_);
- layer->SetTransformAndInvertibility(transform_, transform_is_invertible_);
+ layer->SetTransform(transform_);
if (layer_property_changed_)
layer->NoteLayerPropertyChanged();
@@ -1231,18 +1230,6 @@ void LayerImpl::SetTransform(const gfx::Transform& transform) {
return;
transform_ = transform;
- transform_is_invertible_ = transform_.IsInvertible();
-}
-
-void LayerImpl::SetTransformAndInvertibility(const gfx::Transform& transform,
- bool transform_is_invertible) {
- if (transform_ == transform) {
- DCHECK(transform_is_invertible_ == transform_is_invertible)
- << "Can't change invertibility if transform is unchanged";
- return;
- }
- transform_ = transform;
- transform_is_invertible_ = transform_is_invertible;
}
bool LayerImpl::TransformIsAnimating() const {

Powered by Google App Engine
This is Rietveld 408576698