Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 1905953002: Test files for bug 481. (Closed)

Created:
4 years, 8 months ago by dsinclair
Modified:
4 years, 8 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium_tests@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Test files for bug 481. There are 4 types of meshes that attempt to convert the shading object into a stream. According to spec (section 8.7.4.1 table 76), the shading object can be a stream or a dictionary. All of this shading code assumes it can load the mesh from a stream. The original code just early exited if it was not a stream. We skip the call if it is not a stream. BUG=pdfium:481 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium_tests/+/7e5050a49256a7350df9b8d7ad86e911eb83c021

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+240 lines, -0 lines) Patch
A pdfium/bug_481_coons_patch.pdf View 1 chunk +60 lines, -0 lines 0 comments Download
A + pdfium/bug_481_coons_patch_expected.pdf.0.png View Binary file 0 comments Download
A pdfium/bug_481_free_form_gouraud.pdf View 1 chunk +60 lines, -0 lines 0 comments Download
A + pdfium/bug_481_free_form_gouraud_expected.pdf.0.png View Binary file 0 comments Download
A pdfium/bug_481_lattice_form_gouraud.pdf View 1 chunk +60 lines, -0 lines 0 comments Download
A + pdfium/bug_481_lattice_form_gouraud_expected.pdf.0.png View Binary file 0 comments Download
A pdfium/bug_481_tensor_product.pdf View 1 chunk +60 lines, -0 lines 0 comments Download
A + pdfium/bug_481_tensor_product_expected.pdf.0.png View Binary file 0 comments Download

Messages

Total messages: 6 (3 generated)
dsinclair
PTAL.
4 years, 8 months ago (2016-04-21 14:49:47 UTC) #3
Tom Sepez
lgtm
4 years, 8 months ago (2016-04-21 16:57:06 UTC) #4
dsinclair
4 years, 8 months ago (2016-04-21 16:57:40 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
7e5050a49256a7350df9b8d7ad86e911eb83c021 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698