Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 1905933002: MigrateInstance(target) before Object.assign(target, ...) (Closed)

Created:
4 years, 8 months ago by Toon Verwaest
Modified:
4 years, 7 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MigrateInstance(target) before Object.assign(target, ...) If the target is deprecated, the object will be updated on first store. If the source for that store equals the target, this will invalidate the cached representation of the source. Preventively upgrade the target. BUG=chromium:604300 LOG=n Committed: https://crrev.com/1678bb557c8333283bb88e8853c1aa2cb6eb3d5c Cr-Commit-Position: refs/heads/master@{#35770}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -7 lines) Patch
M src/builtins.cc View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-object-assign-deprecated.js View 1 chunk +3 lines, -3 lines 0 comments Download
A + test/mjsunit/regress/regress-object-assign-deprecated-2.js View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Toon Verwaest
ptal
4 years, 8 months ago (2016-04-21 11:50:05 UTC) #3
Igor Sheludko
lgtm
4 years, 8 months ago (2016-04-21 12:41:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905933002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905933002/40001
4 years, 8 months ago (2016-04-25 15:15:44 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-25 15:40:47 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 15:41:28 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1678bb557c8333283bb88e8853c1aa2cb6eb3d5c
Cr-Commit-Position: refs/heads/master@{#35770}

Powered by Google App Engine
This is Rietveld 408576698