Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: third_party/WebKit/LayoutTests/media/track/track-cues-cuechange.html

Issue 1905923004: Convert track tests from video-test.js to testharness.js based (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/media/track/track-cues-cuechange.html
diff --git a/third_party/WebKit/LayoutTests/media/track/track-cues-cuechange.html b/third_party/WebKit/LayoutTests/media/track/track-cues-cuechange.html
index e63cdd00a9a5190acc6737c99c9f9749f350db99..c0a85e3bbb102d223054bccee6ff43cb788d703a 100644
--- a/third_party/WebKit/LayoutTests/media/track/track-cues-cuechange.html
+++ b/third_party/WebKit/LayoutTests/media/track/track-cues-cuechange.html
@@ -1,90 +1,39 @@
<!DOCTYPE html>
-<html>
- <head>
- <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
-
- <script src=../media-file.js></script>
- <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956
- (Please avoid writing new tests using video-test.js) -->
- <script src=../video-test.js></script>
-
- <script>
-
- var cueChangeCount = 0;
- var currentCue;
- var testTrack;
-
- var trackLoaded = false;
- var videoCanPlayThrough = false;
-
- function attemptTests()
- {
- if (!trackLoaded || !videoCanPlayThrough)
- return;
-
- testTrack = document.getElementById("testTrack");
- testExpected("testTrack.track.cues.length", 3);
- testTrack.addEventListener('cuechange', cueChangedFromTrackElement);
- testTrack.track.addEventListener('cuechange', cueChangedFromTextTrack);
- run("video.play()");
- consoleWrite("");
- }
-
- function cueChangedFromTextTrack()
- {
- consoleWrite("EVENT(cuechange) from TextTrack");
- }
-
- function cueChangedFromTrackElement()
- {
- consoleWrite("EVENT(cuechange) from &lt;track&gt;");
-
- currentCueIndex = Math.floor(cueChangeCount / 2);
- currentCue = event.target.track.cues[currentCueIndex];
- checkCue();
-
- ++cueChangeCount;
- if (cueChangeCount == testTrack.track.cues.length * 2)
- endTest();
- }
-
- function checkCue()
- {
- if (cueChangeCount % 2 == 0) {
- consoleWrite("Cue entered");
- testExpected(currentCue, testTrack.track.activeCues[0]);
- testExpected("currentCue.id", currentCueIndex + 1);
- } else
- consoleWrite("Cue exited");
- consoleWrite("");
- }
-
- waitForEvent('canplaythrough',
- function ()
- {
- videoCanPlayThrough = true;
- attemptTests();
- }
- );
-
- function loaded()
- {
- trackLoaded = true;
- attemptTests();
- }
-
- function start()
- {
- findMediaElement();
- video.src = findMediaFile("video", "../content/test");
+<title>Tests that TextTrack's cues are indexed and updated in order during video playback. Test uses the cuechange event.</title>
+<script src="../media-file.js"></script>
+<script src="../../resources/testharness.js"></script>
+<script src="../../resources/testharnessreport.js"></script>
+<video>
+ <track src="captions-webvtt/cues-chrono-order.vtt" kind="captions" default>
+</video>
+<script>
+async_test(function(t) {
+ var video = document.querySelector("video");
+ var testTrack = document.querySelector("track");
+
+ video.src = findMediaFile("video", "../content/test");
+ video.oncanplaythrough = t.step_func(attemptTests);
+
+ function attemptTests() {
+ assert_equals(testTrack.track.cues.length, 3);
+ testTrack.oncuechange = t.step_func(cueChangedFromTrackElement);
+ video.play();
+ }
+
+ var currentCueIndex;
+ var cueChangeCount = 0;
+ function cueChangedFromTrackElement() {
+ currentCueIndex = Math.floor(cueChangeCount / 2);
+ currentCue = event.target.track.cues[currentCueIndex];
+ if (cueChangeCount % 2 == 0) {
+ // Cue entered.
+ assert_equals(currentCue, testTrack.track.activeCues[0]);
+ assert_equals(currentCue.id, (currentCueIndex + 1).toString());
}
- </script>
- </head>
- <body onload="start()">
- <p>Tests that TextTrack's cues are indexed and updated in order during video playback. Test uses the cuechange event.</p>
- <video controls>
- <track id="testTrack" src="captions-webvtt/cues-chrono-order.vtt" kind="captions" onload="loaded()" default>
- </video>
- </body>
-</html>
+ ++cueChangeCount;
+ if (cueChangeCount == testTrack.track.cues.length * 2)
+ t.done();
+ }
+});
+</script>

Powered by Google App Engine
This is Rietveld 408576698