third_party/WebKit/LayoutTests/media/track/track-cues-missed.html - Issue 1905923004: Convert track tests from video-test.js to testharness.js based

Side by Side Diff: third_party/WebKit/LayoutTests/media/track/track-cues-missed.html

Issue 1905923004: Convert track tests from video-test.js to testharness.js based (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/track/track-cues-enter-exit-expected.txt ('k') | third_party/WebKit/LayoutTests/media/track/track-cues-missed-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <title>Tests that events are triggered for missed (skipped) cues during normal p layback.</title>

3 <head>	3 <script src="../media-file.js"></script>

4 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />	4 <script src="../../resources/testharness.js"></script>

	5 <script src="../../resources/testharnessreport.js"></script>

	6 <video>

	7 <track src="captions-webvtt/missed-cues.vtt" default>

	8 </video>

	9 <script>

	10 async_test(function(t) {

	11 var video = document.querySelector("video");

	12 var testTrack = document.querySelector("track");

5	13

6 <script src=../media-file.js></script>	14 video.src = findMediaFile("video", "../content/test");

7 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956	15

8 (Please avoid writing new tests using video-test.js) -->	16 video.onended = t.step_func_done();

9 <script src=../video-test.js></script>

10 <script>

11 var videoCanPlayThrough = false;

12 var trackLoaded = false;

13	17

14 var currentCue;	18 video.oncanplaythrough = t.step_func(function() {

15 var cueCount;	19 video.oncanplaythrough = null;

16 var testTrack;	20 video.currentTime = 5.00;

	21 runTests();

	22 });

17	23

18 function runTests()	24 testTrack.onload = t.step_func(runTests);

19 {

20 if (!trackLoaded \|\| !videoCanPlayThrough)

21 return;

22	25

23 testTrack = document.getElementById("testTrack");	26 var cueCount;

24 testExpected("testTrack.track.cues.length", 7);	27 var eventCount = 0;

	28 function runTests() {

	29 eventCount++;

25	30

26 for (cueCount = 2; cueCount < testTrack.track.cues.length; cueCo unt++) {	31 if(eventCount != 2)

27 var cue = testTrack.track.cues[cueCount];	32 return;

28	33

29 cue.addEventListener('enter', cueEnteredOrExited);	34 assert_equals(testTrack.track.cues.length, 7);

30 cue.addEventListener('exit', cueEnteredOrExited);

31 }

32	35

33 cueCount = 3;	36 for (cueCount = 2; cueCount < testTrack.track.cues.length; cueCount++) {

34 run("video.play()");	37 var cue = testTrack.track.cues[cueCount];

35 }

36	38

37 function cueEnteredOrExited()	39 cue.onenter = t.step_func(cueEnteredOrExited);

38 {	40 cue.onexit = t.step_func(cueEnteredOrExited);

39 consoleWrite("");	41 }

40 consoleWrite("EVENT(" + event.type + ")");

41	42

42 currentCue = event.target;	43 // Test events for missed cues, which are cues with ids

43 testExpected("testTrack.track.cues.getCueById(cueCount).text", c urrentCue.text, "==");	44 // from 3 to 7 in the file captions-webvtt/missed-cues.vtt.

44 testExpected("currentCue.id", cueCount);	45 cueCount = 3;

	46 video.play();

	47 }

45	48

46 if (event.type == 'exit') {	49 function cueEnteredOrExited() {

47 cueCount++;	50 var currentCue = event.target;

48 }	51 assert_equals(testTrack.track.cues.getCueById(cueCount).text, currentCue .text);

49 }	52 assert_equals(currentCue.id, cueCount.toString());
	Srirama 2016/04/26 06:49:27 toString() for 2nd argument is fine? or is it bett toString() for 2nd argument is fine? or is it better to use parseInt() for the first argument? mlamouri (slow - plz ping) 2016/04/26 14:19:32 Sounds fine. It's pretty much the same. Alternati Show quoted text On 2016/04/26 at 06:49:27, Srirama wrote: > toString() for 2nd argument is fine? or is it better to use parseInt() for the first argument? Sounds fine. It's pretty much the same. Alternatively, you can do `assert_true(foo == bar);`
50	53

51 waitForEvent('ended', endTest);	54 if (event.type == "exit")

	55 cueCount++;

	56 }

52	57

53 waitForEventOnce('canplaythrough', function() {	58 });

54 video.currentTime = 5.00;	59 </script>

55 videoCanPlayThrough = true;

56

57 runTests();

58 });

59

60 function loaded()

61 {

62 trackLoaded = true;

63

64 runTests();

65 };

66

67 function bodyLoaded()

68 {

69 findMediaElement();

70 video.src = findMediaFile("video", "../content/test");

71 }

72 </script>

73 </head>

74 <body onload="bodyLoaded()">

75 <p>Tests that events are triggered for missed (skipped) cues during norm al playback.</p>

76 <video controls>

77 <track id="testTrack" src="captions-webvtt/missed-cues.vtt" onload=" loaded()" default>

78 </video>

79 </body>

80 </html>

OLD	NEW