Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 1905893002: Revert of Makes ScreenMus not check that displays are non-empty (Closed)

Created:
4 years, 8 months ago by kjellander_chromium
Modified:
4 years, 8 months ago
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Makes ScreenMus not check that displays are non-empty (patchset #1 id:1 of https://codereview.chromium.org/1912523002/ ) Reason for revert: Speculative revert for failing interactive_ui_tests on Linux Chromium OS ASan LSan Tests (1), starting with https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/11887 Failure: [ RUN ] DragDropTest.DragDropAcrossMultiDisplay Xlib: extension "RANDR" missing on display ":9". [9809:9809:0420/230942:21040728698:INFO:lock_state_controller.cc(95)] Constructing LockStateController instance 0x61600006c980 Xlib: extension "RANDR" missing on display ":9". ../../ash/drag_drop/drag_drop_interactive_uitest.cc:153: Failure Value of: target_view->dropped() Actual: false Expected: true [9809:9809:0420/230942:21040854605:INFO:lock_state_controller.cc(101)] Destroying LockStateController instance 0x61600006c980 [ FAILED ] DragDropTest.DragDropAcrossMultiDisplay (231 ms) Original issue's description: > Makes ScreenMus not check that displays are non-empty > > WaitForIncomingMethodCall can return in the case of the pipe being > broken (say mus is going down). Adds code to handle that case. > > BUG=594600 > TEST=none > R=ben@chromium.org TBR=ben@chromium.org,sky@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=594600 Committed: https://crrev.com/6523ddafa66f46477ab87cbca0f50bb744c813c3 Cr-Commit-Position: refs/heads/master@{#388714}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -9 lines) Patch
M ui/views/mus/screen_mus.cc View 2 chunks +2 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kjellander_chromium
Created Revert of Makes ScreenMus not check that displays are non-empty
4 years, 8 months ago (2016-04-21 07:50:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905893002/1
4 years, 8 months ago (2016-04-21 07:50:13 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 07:50:37 UTC) #4
kjellander_chromium
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1905873003/ by kjellander@chromium.org. ...
4 years, 8 months ago (2016-04-21 10:37:51 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:32:21 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6523ddafa66f46477ab87cbca0f50bb744c813c3
Cr-Commit-Position: refs/heads/master@{#388714}

Powered by Google App Engine
This is Rietveld 408576698