Chromium Code Reviews
DescriptionRevert of Makes ScreenMus not check that displays are non-empty (patchset #1 id:1 of https://codereview.chromium.org/1912523002/ )
Reason for revert:
Speculative revert for failing interactive_ui_tests on Linux Chromium OS ASan LSan Tests (1), starting with
https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/11887
Failure:
[ RUN ] DragDropTest.DragDropAcrossMultiDisplay
Xlib: extension "RANDR" missing on display ":9".
[9809:9809:0420/230942:21040728698:INFO:lock_state_controller.cc(95)] Constructing LockStateController instance 0x61600006c980
Xlib: extension "RANDR" missing on display ":9".
../../ash/drag_drop/drag_drop_interactive_uitest.cc:153: Failure
Value of: target_view->dropped()
Actual: false
Expected: true
[9809:9809:0420/230942:21040854605:INFO:lock_state_controller.cc(101)] Destroying LockStateController instance 0x61600006c980
[ FAILED ] DragDropTest.DragDropAcrossMultiDisplay (231 ms)
Original issue's description:
> Makes ScreenMus not check that displays are non-empty
>
> WaitForIncomingMethodCall can return in the case of the pipe being
> broken (say mus is going down). Adds code to handle that case.
>
> BUG=594600
> TEST=none
> R=ben@chromium.org
TBR=ben@chromium.org,sky@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=594600
Committed: https://crrev.com/6523ddafa66f46477ab87cbca0f50bb744c813c3
Cr-Commit-Position: refs/heads/master@{#388714}
Patch Set 1 #
Messages
Total messages: 7 (2 generated)
|
|||||||||||||||||||