Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 1905883003: [turbofan] Refined cost model for instruction scheduling on arm64. (Closed)

Created:
4 years, 8 months ago by baptiste.afsa1
Modified:
4 years, 7 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Refined cost model for instruction scheduling on arm64. R=jarin@chromium.org Committed: https://crrev.com/2bc60707775813c555fcd01e4cbeffeb4c0bf3e6 Cr-Commit-Position: refs/heads/master@{#35752}

Patch Set 1 #

Total comments: 1

Patch Set 2 : addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -26 lines) Patch
M src/compiler/arm64/instruction-scheduler-arm64.cc View 1 3 chunks +135 lines, -26 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
baptiste.afsa1
PTAL
4 years, 8 months ago (2016-04-21 15:57:12 UTC) #1
Jarin
lgtm with a nit. https://codereview.chromium.org/1905883003/diff/1/src/compiler/arm64/instruction-scheduler-arm64.cc File src/compiler/arm64/instruction-scheduler-arm64.cc (right): https://codereview.chromium.org/1905883003/diff/1/src/compiler/arm64/instruction-scheduler-arm64.cc#newcode206 src/compiler/arm64/instruction-scheduler-arm64.cc:206: // fallthrough I am not ...
4 years, 8 months ago (2016-04-24 09:32:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905883003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905883003/20001
4 years, 8 months ago (2016-04-25 08:02:36 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-25 08:22:21 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 08:23:15 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2bc60707775813c555fcd01e4cbeffeb4c0bf3e6
Cr-Commit-Position: refs/heads/master@{#35752}

Powered by Google App Engine
This is Rietveld 408576698