Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1485)

Unified Diff: test/cctest/compiler/test-run-machops.cc

Issue 1905883002: X87: Change the test case for X87 RunTruncateFloat32ToUint32. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/compiler/test-run-machops.cc
diff --git a/test/cctest/compiler/test-run-machops.cc b/test/cctest/compiler/test-run-machops.cc
index 6bd00c2ca5a4d581bf78064720c5ec5fb8ce8e2f..e5e69d67c25ef26918fca7df91dfba956a95e928 100644
--- a/test/cctest/compiler/test-run-machops.cc
+++ b/test/cctest/compiler/test-run-machops.cc
@@ -4017,14 +4017,12 @@ TEST(RunTruncateFloat32ToInt32) {
TEST(RunTruncateFloat32ToUint32) {
BufferedRawMachineAssemblerTester<uint32_t> m(MachineType::Float32());
m.Return(m.TruncateFloat32ToUint32(m.Parameter(0)));
- {
- FOR_UINT32_INPUTS(i) {
- float input = static_cast<float>(*i);
- // This condition on 'input' is required because
- // static_cast<float>(std::numeric_limits<uint32_t>::max()) results in a
- // value outside uint32 range.
- if (input < static_cast<float>(std::numeric_limits<uint32_t>::max())) {
- CHECK_EQ(static_cast<uint32_t>(input), m.Call(input));
+ {FOR_UINT32_INPUTS(i){volatile float input = static_cast<float>(*i);
titzer 2016/04/21 07:09:00 This somehow got formatted strangely. Maybe disabl
+ // This condition on 'input' is required because
+ // static_cast<float>(std::numeric_limits<uint32_t>::max()) results in a
+ // value outside uint32 range.
+ if (input < static_cast<float>(std::numeric_limits<uint32_t>::max())) {
+ CHECK_EQ(static_cast<uint32_t>(input), m.Call(input));
}
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698