Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp

Issue 1905873002: Add content_browsertests for testing cache control flags (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review #13 Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
diff --git a/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp b/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
index 7989e4075e9232c8b875e7a2932a71b645731d05..f65cbdef1a1c7b792238964cba956ebfc1232456 100644
--- a/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
+++ b/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
@@ -544,11 +544,6 @@ void ResourceFetcher::initializeRevalidation(const FetchRequest& request, Resour
const AtomicString& lastModified = resource->response().httpHeaderField(HTTPNames::Last_Modified);
const AtomicString& eTag = resource->response().httpHeaderField(HTTPNames::ETag);
hiroshige 2016/05/17 08:50:33 How about adding a comment that says "cache-contro
- if (!lastModified.isEmpty() || !eTag.isEmpty()) {
- ASSERT(context().getCachePolicy() != CachePolicyReload);
- if (context().getCachePolicy() == CachePolicyRevalidate)
- revalidatingRequest.setHTTPHeaderField(HTTPNames::Cache_Control, "max-age=0");
- }
if (!lastModified.isEmpty())
revalidatingRequest.setHTTPHeaderField(HTTPNames::If_Modified_Since, lastModified);
if (!eTag.isEmpty())

Powered by Google App Engine
This is Rietveld 408576698