content/browser/service_worker/service_worker_browsertest.cc - Issue 1905873002: Add content_browsertests for testing cache control flags

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_browsertest.cc

Issue 1905873002: Add content_browsertests for testing cache control flags (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review #13 Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/loader/reload_cache_control_browsertest.cc ('k') | content/content_tests.gypi » ('j') | net/test/embedded_test_server/embedded_test_server.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_browsertest.cc

diff --git a/content/browser/service_worker/service_worker_browsertest.cc b/content/browser/service_worker/service_worker_browsertest.cc

index ac25cc4bcfcecaa278fd5c973763e25aa6c61aa4..8b6d45dcbc2b94aedc39e62e38af7898db7b9480 100644

--- a/content/browser/service_worker/service_worker_browsertest.cc

+++ b/content/browser/service_worker/service_worker_browsertest.cc

@@ -1168,7 +1168,7 @@ IN_PROC_BROWSER_TEST_F(ServiceWorkerBrowserTest, CrossOriginFetchWithSaveData) {

cross_origin_server.ServeFilesFromSourceDirectory("content/test/data");

cross_origin_server.RegisterRequestHandler(

base::Bind(&VerifySaveDataNotInAccessControlRequestHeader));

- cross_origin_server.Start();

+ ASSERT_TRUE(cross_origin_server.Start());

kinuko 2016/05/13 14:10:18 nit: this change looks fine but it's unrelated to

kinuko 2016/05/13 14:11:57 I see, you needed this because you added the warni

MockContentBrowserClient content_browser_client;

content_browser_client.set_data_saver_enabled(true);