Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Unified Diff: net/tools/quic/quic_simple_server_session_test.cc

Issue 1905843003: Split out QuicAlarm creation from QuicConnectionHelper to new QuicAlarmFactory. No behavior change,… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@119753783
Patch Set: Rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/quic/quic_simple_server.cc ('k') | net/tools/quic/quic_simple_server_stream_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/quic_simple_server_session_test.cc
diff --git a/net/tools/quic/quic_simple_server_session_test.cc b/net/tools/quic/quic_simple_server_session_test.cc
index 51dde7a8c4960037e42fc34c16ba097e95ec57e3..af742b2452f1de28c801fddfeb6a551167431f0b 100644
--- a/net/tools/quic/quic_simple_server_session_test.cc
+++ b/net/tools/quic/quic_simple_server_session_test.cc
@@ -106,9 +106,11 @@ class MockQuicCryptoServerStream : public QuicCryptoServerStream {
class MockConnectionWithSendStreamData : public MockConnection {
public:
MockConnectionWithSendStreamData(MockConnectionHelper* helper,
+ MockAlarmFactory* alarm_factory,
Perspective perspective,
const QuicVersionVector& supported_versions)
- : MockConnection(helper, perspective, supported_versions) {}
+ : MockConnection(helper, alarm_factory, perspective, supported_versions) {
+ }
MOCK_METHOD5(SendStreamData,
QuicConsumedData(QuicStreamId id,
@@ -168,7 +170,8 @@ class QuicSimpleServerSessionTest
kInitialSessionFlowControlWindowForTest);
connection_ = new StrictMock<MockConnectionWithSendStreamData>(
- &helper_, Perspective::IS_SERVER, SupportedVersions(GetParam()));
+ &helper_, &alarm_factory_, Perspective::IS_SERVER,
+ SupportedVersions(GetParam()));
session_.reset(new QuicSimpleServerSession(config_, connection_, &owner_,
&crypto_config_,
&compressed_certs_cache_));
@@ -186,6 +189,7 @@ class QuicSimpleServerSessionTest
StrictMock<MockQuicServerSessionVisitor> owner_;
MockConnectionHelper helper_;
+ MockAlarmFactory alarm_factory_;
StrictMock<MockConnectionWithSendStreamData>* connection_;
QuicConfig config_;
QuicCryptoServerConfig crypto_config_;
@@ -403,7 +407,8 @@ class QuicSimpleServerSessionServerPushTest
QuicConfigPeer::SetReceivedConnectionOptions(&config_, copt);
connection_ = new StrictMock<MockConnectionWithSendStreamData>(
- &helper_, Perspective::IS_SERVER, SupportedVersions(GetParam()));
+ &helper_, &alarm_factory_, Perspective::IS_SERVER,
+ SupportedVersions(GetParam()));
session_.reset(new QuicSimpleServerSession(config_, connection_, &owner_,
&crypto_config_,
&compressed_certs_cache_));
« no previous file with comments | « net/tools/quic/quic_simple_server.cc ('k') | net/tools/quic/quic_simple_server_stream_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698