net/tools/quic/quic_server_session_base_test.cc - Issue 1905843003: Split out QuicAlarm creation from QuicConnectionHelper to new QuicAlarmFactory. No behavior change,…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/tools/quic/quic_server_session_base_test.cc

Issue 1905843003: Split out QuicAlarm creation from QuicConnectionHelper to new QuicAlarmFactory. No behavior change,… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@119753783

Patch Set: Rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/tools/quic/quic_server_session_base_test.cc

diff --git a/net/tools/quic/quic_server_session_base_test.cc b/net/tools/quic/quic_server_session_base_test.cc

index fb246fcef97ce94530a3d750fc13d029fec3c31d..9d79a8663e26defbb9ff8dfe42efd60794bc1815 100644

--- a/net/tools/quic/quic_server_session_base_test.cc

+++ b/net/tools/quic/quic_server_session_base_test.cc

@@ -134,8 +134,9 @@ class QuicServerSessionBaseTest : public ::testing::TestWithParam<QuicVersion> {

config_.SetInitialSessionFlowControlWindowToSend(

kInitialSessionFlowControlWindowForTest);

- connection_ = new StrictMock<MockConnection>(

- &helper_, Perspective::IS_SERVER, SupportedVersions(GetParam()));

+ connection_ = new StrictMock<MockConnection>(&helper_, &alarm_factory_,

+ Perspective::IS_SERVER,

+ SupportedVersions(GetParam()));

session_.reset(new TestServerSession(config_, connection_, &owner_,

&crypto_config_,

&compressed_certs_cache_));

@@ -149,6 +150,7 @@ class QuicServerSessionBaseTest : public ::testing::TestWithParam<QuicVersion> {

StrictMock<MockQuicServerSessionVisitor> owner_;

MockConnectionHelper helper_;

+ MockAlarmFactory alarm_factory_;

StrictMock<MockConnection>* connection_;

QuicConfig config_;

QuicCryptoServerConfig crypto_config_;

« no previous file with comments | « net/tools/quic/quic_server.cc ('k') | net/tools/quic/quic_server_test.cc » ('j') | no next file with comments »