Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2131)

Unified Diff: net/tools/quic/quic_epoll_connection_helper.h

Issue 1905843003: Split out QuicAlarm creation from QuicConnectionHelper to new QuicAlarmFactory. No behavior change,… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@119753783
Patch Set: Rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/quic/quic_epoll_alarm_factory_test.cc ('k') | net/tools/quic/quic_epoll_connection_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/quic_epoll_connection_helper.h
diff --git a/net/tools/quic/quic_epoll_connection_helper.h b/net/tools/quic/quic_epoll_connection_helper.h
index fd18fb3432d0fc6f3035ed125bdd085fdb8a1416..ccd7536b2bc58c56a25cf1259a24dddbfb6a5e4a 100644
--- a/net/tools/quic/quic_epoll_connection_helper.h
+++ b/net/tools/quic/quic_epoll_connection_helper.h
@@ -25,12 +25,6 @@ namespace net {
class EpollServer;
class QuicRandom;
-
-class AckAlarm;
-class RetransmissionAlarm;
-class SendAlarm;
-class TimeoutAlarm;
-
using QuicStreamBufferAllocator = SimpleBufferAllocator;
enum class QuicAllocator { SIMPLE, BUFFER_POOL };
@@ -43,20 +37,12 @@ class QuicEpollConnectionHelper : public QuicConnectionHelperInterface {
// QuicEpollConnectionHelperInterface
const QuicClock* GetClock() const override;
QuicRandom* GetRandomGenerator() override;
- QuicAlarm* CreateAlarm(QuicAlarm::Delegate* delegate) override;
- QuicArenaScopedPtr<QuicAlarm> CreateAlarm(
- QuicArenaScopedPtr<QuicAlarm::Delegate> delegate,
- QuicConnectionArena* arena) override;
QuicBufferAllocator* GetBufferAllocator() override;
- EpollServer* epoll_server() { return epoll_server_; }
-
private:
friend class QuicConnectionPeer;
- EpollServer* epoll_server_; // Not owned.
-
const QuicEpollClock clock_;
QuicRandom* random_generator_;
// Set up both allocators. They take up minimal memory before use.
« no previous file with comments | « net/tools/quic/quic_epoll_alarm_factory_test.cc ('k') | net/tools/quic/quic_epoll_connection_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698