net/quic/quic_session_test.cc - Issue 1905843003: Split out QuicAlarm creation from QuicConnectionHelper to new QuicAlarmFactory. No behavior change,…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_session_test.cc

Issue 1905843003: Split out QuicAlarm creation from QuicConnectionHelper to new QuicAlarmFactory. No behavior change,… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@119753783

Patch Set: Rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_session_test.cc

diff --git a/net/quic/quic_session_test.cc b/net/quic/quic_session_test.cc

index 2c180737aba8573b9f51d88d7cfb55debd184fcc..770b15dc8924be519ec1037a21475591ea31bf14 100644

--- a/net/quic/quic_session_test.cc

+++ b/net/quic/quic_session_test.cc

@@ -197,6 +197,7 @@ class QuicSessionTestBase : public ::testing::TestWithParam<QuicVersion> {

explicit QuicSessionTestBase(Perspective perspective)

: connection_(

new StrictMock<MockConnection>(&helper_,

+ &alarm_factory_,

perspective,

SupportedVersions(GetParam()))),

session_(connection_) {

@@ -257,6 +258,7 @@ class QuicSessionTestBase : public ::testing::TestWithParam<QuicVersion> {

QuicVersion version() const { return connection_->version(); }

MockConnectionHelper helper_;

+ MockAlarmFactory alarm_factory_;

StrictMock<MockConnection>* connection_;

TestSession session_;

set<QuicStreamId> closed_streams_;

« no previous file with comments | « net/quic/quic_http_stream_test.cc ('k') | net/quic/quic_spdy_stream_test.cc » ('j') | no next file with comments »