Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Unified Diff: net/quic/quic_client_push_promise_index_test.cc

Issue 1905843003: Split out QuicAlarm creation from QuicConnectionHelper to new QuicAlarmFactory. No behavior change,… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@119753783
Patch Set: Rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_client_promised_info_test.cc ('k') | net/quic/quic_connection.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_client_push_promise_index_test.cc
diff --git a/net/quic/quic_client_push_promise_index_test.cc b/net/quic/quic_client_push_promise_index_test.cc
index 85c7f0cbc48766a471ba9ec2f35fb4a02bbf3898..672fcfc432b1d1c7f1e02ad334dac9468baea145 100644
--- a/net/quic/quic_client_push_promise_index_test.cc
+++ b/net/quic/quic_client_push_promise_index_test.cc
@@ -45,8 +45,9 @@ class MockQuicClientSession : public QuicClientSession {
class QuicClientPushPromiseIndexTest : public ::testing::Test {
public:
QuicClientPushPromiseIndexTest()
- : connection_(
- new StrictMock<MockConnection>(&helper_, Perspective::IS_CLIENT)),
+ : connection_(new StrictMock<MockConnection>(&helper_,
+ &alarm_factory_,
+ Perspective::IS_CLIENT)),
session_(connection_, &index_),
promised_(&session_, kServerDataStreamId1, url_) {
FLAGS_quic_supports_push_promise = true;
@@ -59,6 +60,7 @@ class QuicClientPushPromiseIndexTest : public ::testing::Test {
}
MockConnectionHelper helper_;
+ MockAlarmFactory alarm_factory_;
StrictMock<MockConnection>* connection_;
MockQuicClientSession session_;
QuicClientPushPromiseIndex index_;
« no previous file with comments | « net/quic/quic_client_promised_info_test.cc ('k') | net/quic/quic_connection.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698