Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Unified Diff: net/quic/quic_chromium_connection_helper.h

Issue 1905843003: Split out QuicAlarm creation from QuicConnectionHelper to new QuicAlarmFactory. No behavior change,… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@119753783
Patch Set: Rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_chromium_client_stream_test.cc ('k') | net/quic/quic_chromium_connection_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_chromium_connection_helper.h
diff --git a/net/quic/quic_chromium_connection_helper.h b/net/quic/quic_chromium_connection_helper.h
index 281a3f365f7e6f83b0c363a7bc0f46925d0cdd57..badf8f5104a52acc40c5ac924a942463a4953043 100644
--- a/net/quic/quic_chromium_connection_helper.h
+++ b/net/quic/quic_chromium_connection_helper.h
@@ -8,10 +8,7 @@
#ifndef NET_QUIC_QUIC_CONNECTION_HELPER_H_
#define NET_QUIC_QUIC_CONNECTION_HELPER_H_
-#include <set>
-
#include "base/macros.h"
-#include "base/memory/weak_ptr.h"
#include "net/base/ip_endpoint.h"
#include "net/quic/quic_connection.h"
#include "net/quic/quic_protocol.h"
@@ -19,6 +16,7 @@
#include "net/quic/quic_time.h"
#include "net/udp/datagram_client_socket.h"
+
namespace base {
class TaskRunner;
} // namespace base
@@ -31,26 +29,19 @@ class QuicRandom;
class NET_EXPORT_PRIVATE QuicChromiumConnectionHelper
: public QuicConnectionHelperInterface {
public:
- QuicChromiumConnectionHelper(base::TaskRunner* task_runner,
- const QuicClock* clock,
+ QuicChromiumConnectionHelper(const QuicClock* clock,
QuicRandom* random_generator);
~QuicChromiumConnectionHelper() override;
// QuicConnectionHelperInterface
const QuicClock* GetClock() const override;
QuicRandom* GetRandomGenerator() override;
- QuicAlarm* CreateAlarm(QuicAlarm::Delegate* delegate) override;
- QuicArenaScopedPtr<QuicAlarm> CreateAlarm(
- QuicArenaScopedPtr<QuicAlarm::Delegate> delegate,
- QuicConnectionArena* arena) override;
QuicBufferAllocator* GetBufferAllocator() override;
private:
- base::TaskRunner* task_runner_;
const QuicClock* clock_;
QuicRandom* random_generator_;
SimpleBufferAllocator buffer_allocator_;
- base::WeakPtrFactory<QuicChromiumConnectionHelper> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(QuicChromiumConnectionHelper);
};
« no previous file with comments | « net/quic/quic_chromium_client_stream_test.cc ('k') | net/quic/quic_chromium_connection_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698