Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Unified Diff: net/quic/quic_chromium_client_session_test.cc

Issue 1905843003: Split out QuicAlarm creation from QuicConnectionHelper to new QuicAlarmFactory. No behavior change,… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@119753783
Patch Set: Rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_chromium_alarm_factory_test.cc ('k') | net/quic/quic_chromium_client_stream_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_chromium_client_session_test.cc
diff --git a/net/quic/quic_chromium_client_session_test.cc b/net/quic/quic_chromium_client_session_test.cc
index a17b663cef6dea7689acdb2c16587449a987bd5f..5e208991ee317102198c3567fb914db3aa0695a9 100644
--- a/net/quic/quic_chromium_client_session_test.cc
+++ b/net/quic/quic_chromium_client_session_test.cc
@@ -23,6 +23,7 @@
#include "net/quic/crypto/quic_decrypter.h"
#include "net/quic/crypto/quic_encrypter.h"
#include "net/quic/crypto/quic_server_info.h"
+#include "net/quic/quic_chromium_alarm_factory.h"
#include "net/quic/quic_chromium_connection_helper.h"
#include "net/quic/quic_chromium_packet_reader.h"
#include "net/quic/quic_chromium_packet_writer.h"
@@ -63,7 +64,8 @@ class QuicChromiumClientSessionTest
socket_data_(
new SequencedSocketData(default_read_.get(), 1, nullptr, 0)),
random_(0),
- helper_(base::ThreadTaskRunnerHandle::Get().get(), &clock_, &random_),
+ helper_(&clock_, &random_),
+ alarm_factory_(base::ThreadTaskRunnerHandle::Get().get(), &clock_),
maker_(GetParam(), 0, &clock_, kServerHostname) {
// Advance the time, because timers do not like uninitialized times.
clock_.AdvanceTime(QuicTime::Delta::FromSeconds(1));
@@ -79,7 +81,7 @@ class QuicChromiumClientSessionTest
QuicChromiumPacketWriter* writer =
new net::QuicChromiumPacketWriter(socket.get());
QuicConnection* connection = new QuicConnection(
- 0, kIpEndPoint, &helper_, writer, true, Perspective::IS_CLIENT,
+ 0, kIpEndPoint, &helper_, &alarm_factory_, writer, true, Perspective::IS_CLIENT,
SupportedVersions(GetParam()));
writer->SetConnection(connection);
session_.reset(new QuicChromiumClientSession(
@@ -127,6 +129,7 @@ class QuicChromiumClientSessionTest
MockClock clock_;
MockRandom random_;
QuicChromiumConnectionHelper helper_;
+ QuicChromiumAlarmFactory alarm_factory_;
TransportSecurityState transport_security_state_;
MockCryptoClientStreamFactory crypto_client_stream_factory_;
std::unique_ptr<QuicChromiumClientSession> session_;
« no previous file with comments | « net/quic/quic_chromium_alarm_factory_test.cc ('k') | net/quic/quic_chromium_client_stream_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698