Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Side by Side Diff: net/quic/quic_spdy_stream_test.cc

Issue 1905843003: Split out QuicAlarm creation from QuicConnectionHelper to new QuicAlarmFactory. No behavior change,… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@119753783
Patch Set: Rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/quic/quic_session_test.cc ('k') | net/quic/quic_stream_factory.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/quic_spdy_stream.h" 5 #include "net/quic/quic_spdy_stream.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/strings/string_number_conversions.h" 9 #include "base/strings/string_number_conversions.h"
10 #include "net/quic/quic_connection.h" 10 #include "net/quic/quic_connection.h"
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 "Rgj3RWUoPumQVCxtSOBdX0GlJOEcDTNCzQIm9BSfetog_eP_TfYubKudt5eMsXmN6" 91 "Rgj3RWUoPumQVCxtSOBdX0GlJOEcDTNCzQIm9BSfetog_eP_TfYubKudt5eMsXmN6"
92 "QnyXHeGeK2UINUzJ-D30AFcpqYgH9_1BvYSpi7fc7_ydBU8TaD8ZRxvtnzXqj0RfG" 92 "QnyXHeGeK2UINUzJ-D30AFcpqYgH9_1BvYSpi7fc7_ydBU8TaD8ZRxvtnzXqj0RfG"
93 "tuHghmv3aD-uzSYJ75XDdzKdizZ86IG6Fbn1XFhYZM-fbHhm3mVEXnyRW4ZuNOLFk" 93 "tuHghmv3aD-uzSYJ75XDdzKdizZ86IG6Fbn1XFhYZM-fbHhm3mVEXnyRW4ZuNOLFk"
94 "Fas6LMcVC6Q8QLlHYbXBpdNFuGbuZGUnav5C-2I_-46lL0NGg3GewxGKGHvHEfoyn" 94 "Fas6LMcVC6Q8QLlHYbXBpdNFuGbuZGUnav5C-2I_-46lL0NGg3GewxGKGHvHEfoyn"
95 "EFFlEYHsBQ98rXImL8ySDycdLEFvBPdtctPmWCfTxwmoSMLHU2SCVDhbqMWU5b0yr" 95 "EFFlEYHsBQ98rXImL8ySDycdLEFvBPdtctPmWCfTxwmoSMLHU2SCVDhbqMWU5b0yr"
96 "JBCScs_ejbKaqBDoB7ZGxTvqlrB__2ZmnHHjCr8RgMRtKNtIeuZAo "; 96 "JBCScs_ejbKaqBDoB7ZGxTvqlrB__2ZmnHHjCr8RgMRtKNtIeuZAo ";
97 } 97 }
98 98
99 void Initialize(bool stream_should_process_data) { 99 void Initialize(bool stream_should_process_data) {
100 connection_ = new testing::StrictMock<MockConnection>( 100 connection_ = new testing::StrictMock<MockConnection>(
101 &helper_, Perspective::IS_SERVER, SupportedVersions(GetParam())); 101 &helper_, &alarm_factory_, Perspective::IS_SERVER,
102 SupportedVersions(GetParam()));
102 session_.reset(new testing::StrictMock<MockQuicSpdySession>(connection_)); 103 session_.reset(new testing::StrictMock<MockQuicSpdySession>(connection_));
103 stream_ = new TestStream(kClientDataStreamId1, session_.get(), 104 stream_ = new TestStream(kClientDataStreamId1, session_.get(),
104 stream_should_process_data); 105 stream_should_process_data);
105 session_->ActivateStream(stream_); 106 session_->ActivateStream(stream_);
106 stream2_ = new TestStream(kClientDataStreamId2, session_.get(), 107 stream2_ = new TestStream(kClientDataStreamId2, session_.get(),
107 stream_should_process_data); 108 stream_should_process_data);
108 session_->ActivateStream(stream2_); 109 session_->ActivateStream(stream2_);
109 } 110 }
110 111
111 protected: 112 protected:
112 MockConnectionHelper helper_; 113 MockConnectionHelper helper_;
114 MockAlarmFactory alarm_factory_;
113 MockConnection* connection_; 115 MockConnection* connection_;
114 std::unique_ptr<MockQuicSpdySession> session_; 116 std::unique_ptr<MockQuicSpdySession> session_;
115 117
116 // Owned by the |session_|. 118 // Owned by the |session_|.
117 TestStream* stream_; 119 TestStream* stream_;
118 TestStream* stream2_; 120 TestStream* stream2_;
119 121
120 SpdyHeaderBlock headers_; 122 SpdyHeaderBlock headers_;
121 }; 123 };
122 124
(...skipping 866 matching lines...) Expand 10 before | Expand all | Expand 10 after
989 991
990 // Writing Trailers should fail, as the FIN has already been sent. 992 // Writing Trailers should fail, as the FIN has already been sent.
991 // populated with the number of body bytes written. 993 // populated with the number of body bytes written.
992 EXPECT_DFATAL(stream_->WriteTrailers(SpdyHeaderBlock(), nullptr), 994 EXPECT_DFATAL(stream_->WriteTrailers(SpdyHeaderBlock(), nullptr),
993 "Trailers cannot be sent after a FIN"); 995 "Trailers cannot be sent after a FIN");
994 } 996 }
995 997
996 } // namespace 998 } // namespace
997 } // namespace test 999 } // namespace test
998 } // namespace net 1000 } // namespace net
OLDNEW
« no previous file with comments | « net/quic/quic_session_test.cc ('k') | net/quic/quic_stream_factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698