Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 1905803002: Fix undefined method errors adding no-op stubs for methods needed by dart2js but irrelevant in ddc.… (Closed)

Created:
4 years, 8 months ago by Jacob
Modified:
4 years, 8 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix undefined method errors adding no-op stubs for methods needed by dart2js but irrelevant in ddc. We could later optimize ddc by providing a custom dart:html that doesn't use these methods. Fixes https://github.com/dart-lang/dev_compiler/issues/506 BUG= Committed: https://github.com/dart-lang/dev_compiler/commit/665cb0ea7c8268a3d7e2123634648e01c9ad9400

Patch Set 1 #

Total comments: 4

Patch Set 2 : ptal #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -40 lines) Patch
M lib/runtime/dart_sdk.js View 1 13 chunks +45 lines, -20 lines 0 comments Download
M tool/input_sdk/private/interceptors.dart View 1 1 chunk +10 lines, -0 lines 0 comments Download
M tool/input_sdk/private/native_helper.dart View 1 1 chunk +13 lines, -0 lines 0 comments Download
M tool/sdk_expected_errors.txt View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jacob
4 years, 8 months ago (2016-04-20 23:04:07 UTC) #2
vsm
https://codereview.chromium.org/1905803002/diff/1/tool/input_sdk/private/interceptors.dart File tool/input_sdk/private/interceptors.dart (right): https://codereview.chromium.org/1905803002/diff/1/tool/input_sdk/private/interceptors.dart#newcode109 tool/input_sdk/private/interceptors.dart:109: // and cross-frame dom objects behave correctly in ddc. ...
4 years, 8 months ago (2016-04-20 23:11:00 UTC) #3
Jacob
https://codereview.chromium.org/1905803002/diff/1/tool/input_sdk/private/interceptors.dart File tool/input_sdk/private/interceptors.dart (right): https://codereview.chromium.org/1905803002/diff/1/tool/input_sdk/private/interceptors.dart#newcode109 tool/input_sdk/private/interceptors.dart:109: // and cross-frame dom objects behave correctly in ddc. ...
4 years, 8 months ago (2016-04-21 01:02:39 UTC) #4
Jacob
4 years, 8 months ago (2016-04-21 01:03:34 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
665cb0ea7c8268a3d7e2123634648e01c9ad9400 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698