Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 1905763002: Convert //media/cast from scoped_ptr to std::unique_ptr (Closed)

Created:
4 years, 8 months ago by dcheng
Modified:
4 years, 8 months ago
Reviewers:
hubbe, miu
CC:
avayvod+watch_chromium.org, cbentzel+watch_chromium.org, chromium-reviews, feature-media-reviews_chromium.org, imcheng+watch_chromium.org, isheriff+watch_chromium.org, jasonroberts+watch_google.com, jshin+watch_chromium.org, miu+watch_chromium.org, posciak+watch_chromium.org, xjz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert //media/cast from scoped_ptr to std::unique_ptr BUG=554298 R=miu@chromium.org NOPRESUBMIT=true Committed: https://crrev.com/8a9783e4c8d986f835f8cc2760267d6c1c7b0b57 Cr-Commit-Position: refs/heads/master@{#388919}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+791 lines, -739 lines) Patch
M media/cast/cast_config.h View 1 chunk +2 lines, -2 lines 0 comments Download
M media/cast/cast_environment.h View 3 chunks +4 lines, -3 lines 0 comments Download
M media/cast/cast_environment.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/cast_receiver.h View 4 chunks +8 lines, -6 lines 0 comments Download
M media/cast/cast_sender.h View 3 chunks +4 lines, -3 lines 0 comments Download
M media/cast/cast_sender_impl.h View 2 chunks +5 lines, -4 lines 0 comments Download
M media/cast/cast_sender_impl.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M media/cast/common/transport_encryption_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/cast/logging/encoding_event_subscriber_unittest.cc View 32 chunks +37 lines, -36 lines 0 comments Download
M media/cast/logging/log_deserializer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/cast/logging/log_event_dispatcher.h View 3 chunks +9 lines, -9 lines 0 comments Download
M media/cast/logging/log_event_dispatcher.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M media/cast/logging/log_serializer.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M media/cast/logging/raw_event_subscriber_bundle.h View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/logging/receiver_time_offset_estimator_impl_unittest.cc View 17 chunks +18 lines, -17 lines 0 comments Download
M media/cast/logging/serialize_deserialize_test.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M media/cast/logging/simple_event_subscriber_unittest.cc View 6 chunks +10 lines, -10 lines 0 comments Download
M media/cast/logging/stats_event_subscriber.h View 3 chunks +4 lines, -3 lines 0 comments Download
M media/cast/logging/stats_event_subscriber.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M media/cast/logging/stats_event_subscriber_unittest.cc View 25 chunks +26 lines, -25 lines 0 comments Download
M media/cast/net/cast_transport.h View 3 chunks +10 lines, -9 lines 0 comments Download
M media/cast/net/cast_transport_config.h View 2 chunks +4 lines, -3 lines 0 comments Download
M media/cast/net/cast_transport_impl.h View 7 chunks +12 lines, -12 lines 0 comments Download
M media/cast/net/cast_transport_impl.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M media/cast/net/cast_transport_impl_unittest.cc View 6 chunks +13 lines, -11 lines 0 comments Download
M media/cast/net/pacing/paced_sender.h View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/net/pacing/paced_sender_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/net/rtcp/receiver_rtcp_event_subscriber_unittest.cc View 8 chunks +13 lines, -12 lines 0 comments Download
M media/cast/net/rtcp/rtcp_builder_unittest.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M media/cast/net/rtcp/rtcp_defines.h View 2 chunks +5 lines, -5 lines 0 comments Download
M media/cast/net/rtcp/rtcp_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/cast/net/rtcp/rtcp_utility_unittest.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M media/cast/net/rtcp/test_rtcp_packet_builder.h View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/net/rtcp/test_rtcp_packet_builder.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/cast/net/rtp/cast_message_builder_unittest.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M media/cast/net/rtp/framer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/cast/net/rtp/rtp_packetizer_unittest.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M media/cast/net/rtp/rtp_parser_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M media/cast/net/rtp/rtp_sender.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/cast/net/udp_transport.h View 2 chunks +4 lines, -3 lines 0 comments Download
M media/cast/net/udp_transport_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/receiver/audio_decoder.h View 2 chunks +4 lines, -3 lines 0 comments Download
M media/cast/receiver/audio_decoder.cc View 9 chunks +17 lines, -16 lines 0 comments Download
M media/cast/receiver/audio_decoder_unittest.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M media/cast/receiver/cast_receiver_impl.h View 5 chunks +10 lines, -11 lines 0 comments Download
M media/cast/receiver/cast_receiver_impl.cc View 7 chunks +11 lines, -9 lines 0 comments Download
M media/cast/receiver/frame_receiver.h View 3 chunks +3 lines, -3 lines 0 comments Download
M media/cast/receiver/frame_receiver.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M media/cast/receiver/frame_receiver_unittest.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M media/cast/receiver/video_decoder.h View 2 chunks +3 lines, -2 lines 0 comments Download
M media/cast/receiver/video_decoder.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M media/cast/receiver/video_decoder_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/cast/sender/audio_encoder.h View 3 chunks +4 lines, -3 lines 0 comments Download
M media/cast/sender/audio_encoder.cc View 9 chunks +11 lines, -12 lines 0 comments Download
M media/cast/sender/audio_encoder_unittest.cc View 5 chunks +8 lines, -7 lines 0 comments Download
M media/cast/sender/audio_sender.h View 3 chunks +5 lines, -4 lines 0 comments Download
M media/cast/sender/audio_sender.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/cast/sender/audio_sender_unittest.cc View 6 chunks +19 lines, -19 lines 0 comments Download
M media/cast/sender/congestion_control.h View 1 chunk +2 lines, -1 line 0 comments Download
M media/cast/sender/congestion_control_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/sender/external_video_encoder.h View 4 chunks +5 lines, -4 lines 0 comments Download
M media/cast/sender/external_video_encoder.cc View 6 chunks +12 lines, -14 lines 0 comments Download
M media/cast/sender/external_video_encoder_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M media/cast/sender/fake_video_encode_accelerator_factory.h View 2 chunks +4 lines, -3 lines 0 comments Download
M media/cast/sender/frame_sender.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/cast/sender/frame_sender.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M media/cast/sender/h264_vt_encoder.h View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/sender/h264_vt_encoder.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M media/cast/sender/h264_vt_encoder_unittest.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M media/cast/sender/size_adaptable_video_encoder_base.h View 5 chunks +6 lines, -5 lines 0 comments Download
M media/cast/sender/size_adaptable_video_encoder_base.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M media/cast/sender/video_encoder.h View 4 chunks +5 lines, -4 lines 0 comments Download
M media/cast/sender/video_encoder.cc View 3 chunks +14 lines, -19 lines 0 comments Download
M media/cast/sender/video_encoder_impl.h View 2 chunks +3 lines, -2 lines 0 comments Download
M media/cast/sender/video_encoder_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/sender/video_encoder_unittest.cc View 5 chunks +17 lines, -15 lines 0 comments Download
M media/cast/sender/video_frame_factory.h View 1 chunk +2 lines, -1 line 0 comments Download
M media/cast/sender/video_sender.h View 3 chunks +5 lines, -4 lines 0 comments Download
M media/cast/sender/video_sender.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M media/cast/sender/video_sender_unittest.cc View 6 chunks +16 lines, -14 lines 0 comments Download
M media/cast/sender/vp8_encoder.h View 1 chunk +2 lines, -1 line 0 comments Download
M media/cast/sender/vp8_quantizer_parser_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M media/cast/test/cast_benchmarks.cc View 10 chunks +19 lines, -17 lines 0 comments Download
M media/cast/test/end2end_unittest.cc View 18 chunks +30 lines, -29 lines 0 comments Download
M media/cast/test/fake_media_source.h View 2 chunks +7 lines, -7 lines 0 comments Download
M media/cast/test/fake_media_source.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M media/cast/test/linux_output_window.h View 1 chunk +2 lines, -2 lines 0 comments Download
M media/cast/test/loopback_transport.h View 2 chunks +4 lines, -3 lines 0 comments Download
M media/cast/test/loopback_transport.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M media/cast/test/receiver.cc View 8 chunks +7 lines, -7 lines 0 comments Download
M media/cast/test/sender.cc View 10 chunks +32 lines, -29 lines 0 comments Download
M media/cast/test/simulator.cc View 10 chunks +35 lines, -33 lines 0 comments Download
M media/cast/test/utility/audio_utility.h View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/test/utility/audio_utility.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/cast/test/utility/in_process_receiver.h View 6 chunks +10 lines, -9 lines 0 comments Download
M media/cast/test/utility/in_process_receiver.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M media/cast/test/utility/net_utility.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M media/cast/test/utility/standalone_cast_environment.cc View 2 chunks +2 lines, -1 line 0 comments Download
M media/cast/test/utility/tap_proxy.cc View 7 chunks +9 lines, -9 lines 0 comments Download
M media/cast/test/utility/udp_proxy.h View 5 chunks +29 lines, -26 lines 0 comments Download
M media/cast/test/utility/udp_proxy.cc View 32 chunks +60 lines, -61 lines 0 comments Download
M media/cast/test/utility/udp_proxy_main.cc View 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
dcheng
4 years, 8 months ago (2016-04-20 22:09:28 UTC) #1
dcheng
+miu, mind taking a look at this?
4 years, 8 months ago (2016-04-21 20:46:02 UTC) #3
miu
lgtm
4 years, 8 months ago (2016-04-21 20:57:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905763002/1
4 years, 8 months ago (2016-04-21 20:58:32 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/171642)
4 years, 8 months ago (2016-04-21 21:09:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905763002/1
4 years, 8 months ago (2016-04-21 21:10:48 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 22:13:02 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:40:20 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8a9783e4c8d986f835f8cc2760267d6c1c7b0b57
Cr-Commit-Position: refs/heads/master@{#388919}

Powered by Google App Engine
This is Rietveld 408576698