Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1048)

Issue 1905753002: Image filters: remove SkBitmap-based cache. (Closed)

Created:
4 years, 8 months ago by Stephen White
Modified:
4 years, 8 months ago
Reviewers:
robertphillips, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #include cleanup #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -50 lines) Patch
M include/core/SkImageFilter.h View 1 2 chunks +0 lines, -5 lines 0 comments Download
M include/effects/SkMatrixConvolutionImageFilter.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkImageFilter.cpp View 1 2 6 chunks +3 lines, -45 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
Stephen White
robertphillips: PTAL. Thanks!
4 years, 8 months ago (2016-04-20 21:47:59 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905753002/1
4 years, 8 months ago (2016-04-20 21:48:30 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905753002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905753002/40001
4 years, 8 months ago (2016-04-20 21:58:48 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-20 22:07:47 UTC) #10
robertphillips
lgtm
4 years, 8 months ago (2016-04-20 23:19:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905753002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905753002/40001
4 years, 8 months ago (2016-04-21 00:32:26 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/8923)
4 years, 8 months ago (2016-04-21 00:33:56 UTC) #15
Stephen White
(TBR'ing reed@, since this is just a removal CL.)
4 years, 8 months ago (2016-04-21 13:48:07 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905753002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905753002/40001
4 years, 8 months ago (2016-04-21 13:48:20 UTC) #20
commit-bot: I haz the power
4 years, 8 months ago (2016-04-21 13:49:20 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/32eaa8993da28f9ec4f5c4d392265c096086eb91

Powered by Google App Engine
This is Rietveld 408576698