Improve BindBufferBase/BindBufferRange in GPU command buffer.

gpu/command_buffer/service/context_group.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/context_group.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
@@ skipping 83 matching lines @@
       max_fragment_uniform_vectors_(0u),
       max_varying_vectors_(0u),
       max_vertex_uniform_vectors_(0u),
       max_color_attachments_(1u),
       max_draw_buffers_(1u),
       max_dual_source_draw_buffers_(0u),
       max_vertex_output_components_(0u),
       max_fragment_input_components_(0u),
       min_program_texel_offset_(0),
       max_program_texel_offset_(0),
+      max_transform_feedback_separate_attribs_(0u),
+      max_uniform_buffer_bindings_(0u),
+      uniform_buffer_offset_alignment_(1u),
       program_cache_(NULL),
       feature_info_(feature_info) {
   {
     if (!mailbox_manager_.get())
       mailbox_manager_ = new MailboxManagerImpl;
     if (!subscription_ref_set_.get())
       subscription_ref_set_ = new SubscriptionRefSet();
     if (!pending_valuebuffer_state_.get())
       pending_valuebuffer_state_ = new ValueStateMap();
     if (!feature_info.get())
@@ skipping 55 matching lines @@
     GetIntegerv(GL_MAX_DRAW_BUFFERS_ARB, &max_draw_buffers_);
     if (max_draw_buffers_ < 1)
       max_draw_buffers_ = 1;
   }
   if (feature_info_->feature_flags().ext_blend_func_extended) {
     GetIntegerv(GL_MAX_DUAL_SOURCE_DRAW_BUFFERS_EXT,
                 &max_dual_source_draw_buffers_);
     DCHECK(max_dual_source_draw_buffers_ >= 1);
   }
 
+  if (feature_info_->gl_version_info().IsES3Capable()) {
+    const GLint kMinTransformFeedbackSeparateAttribs = 4;
+    if (!QueryGLFeatureU(GL_MAX_TRANSFORM_FEEDBACK_SEPARATE_ATTRIBS,
+                         kMinTransformFeedbackSeparateAttribs,
+                         &max_transform_feedback_separate_attribs_)) {
+      LOG(ERROR) << "ContextGroup::Initialize failed because maximum "

[piman, 2016/04/20 21:14:35]

nit: DLOG

[Zhenyao Mo, 2016/04/20 22:08:50]

This is consistent with the rest of the code.

We will want to know why we fail to create a context since these messages will
be displayed in about:gpu page.  If we use dlog, we lose them in official
release.

[piman, 2016/04/20 22:14:52]

We should stop doing that. Strings and logging code take a lot of space.

+                 << "transform feedback separate attribs is too small ("
+                 << max_transform_feedback_separate_attribs_ << ", should be "
+                 << kMinTransformFeedbackSeparateAttribs << ").";
+      return false;
+    }
+
+    const GLint kMinUniformBufferBindings = 24;
+    if (!QueryGLFeatureU(GL_MAX_UNIFORM_BUFFER_BINDINGS,
+                         kMinUniformBufferBindings,
+                         &max_uniform_buffer_bindings_)) {
+      LOG(ERROR) << "ContextGroup::Initialize failed because maximum "

[piman, 2016/04/20 21:14:35]

nit: DLOG

[Zhenyao Mo, 2016/04/20 22:08:50]

Same here.

+                 << "uniform buffer bindings is too small ("
+                 << max_uniform_buffer_bindings_ << ", should be "
+                 << kMinUniformBufferBindings << ").";
+      return false;
+    }
+
+    // TODO(zmo): Should we check max UNIFORM_BUFFER_OFFSET_ALIGNMENT is 256?
+    GetIntegerv(GL_UNIFORM_BUFFER_OFFSET_ALIGNMENT,
+                &uniform_buffer_offset_alignment_);
+  }
+
   buffer_manager_.reset(
       new BufferManager(memory_tracker_.get(), feature_info_.get()));
   framebuffer_manager_.reset(new FramebufferManager(
       max_draw_buffers_, max_color_attachments_, feature_info_->context_type(),
       framebuffer_completeness_cache_));
   renderbuffer_manager_.reset(new RenderbufferManager(
       memory_tracker_.get(), max_renderbuffer_size, max_samples,
       feature_info_.get()));
   shader_manager_.reset(new ShaderManager());
   sampler_manager_.reset(new SamplerManager(feature_info_.get()));
@@ skipping 377 matching lines @@
     GLuint client_id, GLuint* service_id) const {
   Buffer* buffer = buffer_manager_->GetBuffer(client_id);
   if (!buffer)
     return false;
   *service_id = buffer->service_id();
   return true;
 }
 
 }  // namespace gles2
 }  // namespace gpu