Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1905693002: Ensure files passed to the editor by RunEditor end in a new line (Closed)

Created:
4 years, 8 months ago by gab
Modified:
4 years, 8 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Ensure files passed to the editor by RunEditor end in a new line BUG=605201 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300049

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M gclient_utils.py View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
gab
M-A PTAL :-)
4 years, 8 months ago (2016-04-20 18:27:23 UTC) #3
M-A Ruel
lgtm
4 years, 8 months ago (2016-04-20 18:29:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905693002/1
4 years, 8 months ago (2016-04-20 18:29:06 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-20 18:31:38 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300049

Powered by Google App Engine
This is Rietveld 408576698