Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 1905683004: Include scaler context flags (gamma and contrast boost) in the text blob cache key. (Closed)

Created:
4 years, 8 months ago by Brian Osman
Modified:
4 years, 8 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Include scaler context flags (gamma and contrast boost) in the text blob cache key. Fixes a bug in skiaserve when switching between L32 and S32 modes - we were reusing blobs created with the other (wrong) masks. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1905683004 Committed: https://skia.googlesource.com/skia/+/8d7ffcee75661a50ce298dc1b3bc0b76bea018e7

Patch Set 1 #

Patch Set 2 : Remove leftover changes from earlier version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/gpu/text/GrAtlasTextBlob.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/text/GrAtlasTextContext.cpp View 1 3 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905683004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905683004/20001
4 years, 8 months ago (2016-04-21 14:25:54 UTC) #3
Brian Osman
4 years, 8 months ago (2016-04-21 14:26:15 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-21 14:36:07 UTC) #7
bsalomon
lgtm
4 years, 8 months ago (2016-04-21 15:24:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905683004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905683004/20001
4 years, 8 months ago (2016-04-21 15:28:15 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-21 15:29:09 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/8d7ffcee75661a50ce298dc1b3bc0b76bea018e7

Powered by Google App Engine
This is Rietveld 408576698